Half-life rounding errors about build-a-nucleus HOT 8 CLOSED

@chrisklus suggested this is probably related to an issue in ScientificNotationNode. We will look into that.

Thanks!

from build-a-nucleus.

Definitely an issue in ScientificNotationNode, investigating in phetsims/scenery-phet#747.

from build-a-nucleus.

Labeling this issue as blocks-sim-publication, since phetsims/scenery-phet#747 is in-progress.

from build-a-nucleus.

@Luisav1 @chrisklus what is the priority of this issue, and when do you need it resolved? (phetsims/scenery-phet#747 has turned into a real can of worms.)

from build-a-nucleus.

ScientificNotationNode has been greatly improved, and is ready for review in phetsims/scenery-phet#747. It still exhibits some problems that are inherent in floating-point calculations. phetsims/scenery-phet#747 (comment) summarizes the remaining problems. In 6/30 dev meeting, @kathy-phet made the call that those problems are not blocking for build-a-nucleus, will not be addressed specifically for ScientificNotationNode, and will eventually be investigated more generally (perhaps by looking at a library like math.js).

Let me know if you need anything else here.

from build-a-nucleus.

Thanks @Nancy-Salpepi and @pixelzoom! @chrisklus, @marlitas and I just checked that the numbers are being rounded correctly now. Nancy could you review that it's working correctly now and close it if so?

from build-a-nucleus.

@Luisav1 the rounding twice error seems to have been fixed. I did find this one case though and I am wondering if there is an error in the spreadsheet?
For

The sim says 3.0 x10^-2 instead of 3.1x10^-2.

That is the only one I noticed, but obviously didn't try all of them.

from build-a-nucleus.

@Luisav1 and I investigated, and traced the above bug back to phetsims/scenery-phet#613 (comment). This is a known problem in common code, and not something that we are going to fix as part of this issue. Closing

from build-a-nucleus.