Code Monkey home page Code Monkey logo

Comments (14)

zepumph avatar zepumph commented on September 18, 2024

This was simple enough to do that I decided to implement it as the design conversation. @ariel-phet, do you like the offset applied on main? We can make it less or more, or get rid of it. I personally feel like it is an improvement.

from build-a-nucleus.

zepumph avatar zepumph commented on September 18, 2024

@Nancy-Salpepi FYI in case you have thoughts.

from build-a-nucleus.

Nancy-Salpepi avatar Nancy-Salpepi commented on September 18, 2024

@zepumph I think this is great. It is more user friendly for sure.

from build-a-nucleus.

Nancy-Salpepi avatar Nancy-Salpepi commented on September 18, 2024

Wondering if we need this much offset @zepumph? I see that in Expression Exchange it is a lot less and doesn't look so jumpy.

from build-a-nucleus.

ariel-phet avatar ariel-phet commented on September 18, 2024

@zepumph @Nancy-Salpepi I don't have access to a great touch device currently.

I think the idea of an offset is appropriate, and in this case I think @Nancy-Salpepi is well qualified to make the call of what looks best. I would say fine tune with her!

from build-a-nucleus.

zepumph avatar zepumph commented on September 18, 2024

To find the perfect number, I made a query parameter ?particleTouchOffset=20. @Nancy-Salpepi you tested with a value of 30 and thought it was a bit too much. The current default is 20. Let me know what you want the value to be.

Wondering if we need this much offset @zepumph? I see that in Expression Exchange it is a lot less and doesn't look so jumpy.

In expression exchange we have a bit of an easier time because the object is bigger, so you don't have to move it as much to make it visible above your finger. The particles are pretty tiny.

I personally don't mind a jump too much if it means that the particle is clearly visible as I drag. I tried a value of 15 and couldn't really see the particle still (but it also didn't jump)! That said I have fat fingers.

I don't really have an opinion here, but wanted to give you the data I found while working on this. Let me know what you like and we should do that.

from build-a-nucleus.

Nancy-Salpepi avatar Nancy-Salpepi commented on September 18, 2024

@zepumph the behavior I see today with ?particleTouchOffset=30 is not the same as the other day. The particle is much closer to my fingertip and not jumpy. Was there another change that may have cause this?

from build-a-nucleus.

zepumph avatar zepumph commented on September 18, 2024

Hmmm, not that I know of. Weird!

from build-a-nucleus.

Nancy-Salpepi avatar Nancy-Salpepi commented on September 18, 2024

Is the behavior the same for you today as it was the other day @zepumph?

from build-a-nucleus.

Nancy-Salpepi avatar Nancy-Salpepi commented on September 18, 2024

The current behavior I am seeing with ?particleTouchOffset=30 looks good to me. What I initially saw and commented on in #197 (comment) was behavior similar to ?particleTouchOffset=70. Not sure why there was this inconsistency.

from build-a-nucleus.

zepumph avatar zepumph commented on September 18, 2024

Is the behavior the same for you today as it was the other day @zepumph?

Ahh shoot. I totally gas-lit you. I thought that I originally set it to 30, but I actually set it to 60 before. So sorry. It is 30 now and the query parameter has been removed. Do you like it?

from build-a-nucleus.

zepumph avatar zepumph commented on September 18, 2024

After discussing with @Nancy-Salpepi, we brought back the query parameter to play with more. Note that this really depends on the size of the window. A small sim will definitely hide at 30, but 30 in a full screen sim seems really nice on my screen. @Nancy-Salpepi let me know what you like!

from build-a-nucleus.

Nancy-Salpepi avatar Nancy-Salpepi commented on September 18, 2024

I tested on both the iPad and iPhone. Once I zoom in a bit, my finger doesn't hide the particle at 30 on the phone. Let's stick with 30.
I think I decided what house to buy and planned my entire wedding faster than I made this decision 😂.

from build-a-nucleus.

Luisav1 avatar Luisav1 commented on September 18, 2024

@zepumph and I removed the touchOffset query parameter and made it permanently 30. Closing.

from build-a-nucleus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.