phetsims / arithmetic Goto Github PK

Please use the unicode multiply symbol instead of the letter 'x' in all places where multiplication is indicated. See http://www.fileformat.info/info/unicode/char/d7/index.htm for details.

After completing a level in the Factor tab, you cannot retry the same level. Tested on OSX 10.8 Chrome 35.0.1916.153

In a review with @dubson and @gruneich, we decided that the layout of the control panel would be better like this:
Level
Score
Time
RefreshButton

Ready for initial functional review by PhET

The "smile" face disappears from the screen after a couple of seconds when the user enters a correct answer, but the "grimace" face stays on the screen when they enter a value that is incorrect. The grimace should disappear the same way the smile does.

This was probably implemented this way because in the original Flash version of the sim, the feedback for an incorrect value stayed on the screen. Hence, this should probably be considered a spec change, and MLL can implement it or leave it to PhET at their discretion.

This was requested during 6/26/2014 design meeting. Commit 1c37863 was made during the meeting and approved by the team.

animation cycling

Steps to reproduce:

1. launch the task
2. start multiplying
3. change a browser tab
4. come back to the arithmetic
5. see a bug

Although I know @dubson desires this font for its "drawn on a chalk board" feel, it renders very poorly and aliased on chrome. In addition the team felt the "fun factor" is being compromised by poor look.

Recommend changing to a simple sans serif font

You can launch timer after several answers. For example you can launch it before giveng the last answer and get a time record. At the original model the timer can be launched but time stands 0.0

In a review meeting on 6/13/2014, several color changes were recommended by the original designer of the sim and the current redesign lead. This ticket is meant to track these changes.

• The scoreboard color should be lightened so that there is more contrast with the textual labels.
• The background of the level selection screen should be a blue color, perhaps the color of the scoreboard.
• The 'Refresh' and 'ReturnToLevelSelection' buttons are fairly orange, and they are more yellow in other sims. The color should be moved towards yellow.

The button that allows the timer to be turned on and off from within a challenge should be removed. Timer control should only be allowed from the level selection screen.

This is a change to the original spec quoted by MLL, so MLL should estimate the cost of this change and PhET can determine whether to do it internally or have MLL do it.

The pointing hand can be moved onto correct answers numbers shading them down.

The control panel is right justified in the current version. It would look better if it was horizontally centered above the keypad.

On the 'Factor' screen, if the user answers several questions and then presses the refresh button, the previously filled in entries in the grid can no longer be selected as answers.

Link to v1.0.0-dev.3: http://www.colorado.edu/physics/phet/dev/html/arithmetic/1.0.0-dev.3/arithmetic_en.html

The level selection screen should depict the user's best times. There is common code support for this. An example of how this feature looks can be seen in the screenshot below, taken from version 1.0.0 of the Graphing Lines simulation:

that if the user is using a mouse and keyboard, the sim should allow number entry with the keyboard so that they don’t have to use the mouse if they don’t want.

The face frowns on a wrong answer in version 1.0.0-dev.3. As specified, it should grimace instead.

By holding down the corner of a level, you can move the three level buttons up the page.
Tested on OSX 10.9.3 Chrome 35.0.1916.153 and Safari 7.0.4

Steps to reproduce
-Open one of the tabs
-Hold down one of the level buttons in the top corners
-The buttons will move up the page

If you complete a level, and then press the "Continue" button, you are returned to the level selection screen, which is correct. If you then select that level again, the board is blank. If you return to the level selection screen by pressing the star button, the level selection progress indicator (the stars contained in the button) show the level to be complete.

The board should preserve the user's work even if they have completed the level.

Tested on http://www.colorado.edu/physics/phet/dev/html/arithmetic/1.0.0-dev.4/

As discussed in the 6/26/2014 design review meeting, the icons could use some improvement. @amanda-phet has agreed to work on this.

timer shouldn't stop while changing divide/multiply/factor

If the user has not entered an answer, the yellow “enter” button should be grayed out - the background of the button should be gray instead of yellow.

This is part of mid-development code review, see #1.

In order to make the structure clearer and to facilitate reuse of screens, PhET is now generally putting the screens in a separate file. So, rather that this (taken from arithmetic-main.js as of cfe3ac6):

// create and start the sim
new Sim( simTitle, [
  new Screen( '', new MultiplyScreenIconNode(),
    function() {return new MultiplyModel();},
    function( model ) {return new MultiplyScreen( model );},
    { backgroundColor: BACKGROUND_COLOR }
  ), ...

...it should look like this:

new Sim( simTitle, [ MultiplyScreen, ... ] );

The classes that are currently named XxxScreen, such as ArithmeticScreen, MultiplyScreen, etc are actually descendants of ScreenView and should thus be renamed XxxScreenView or simply XxxView if preferred. You can check out Balancing Act starting with balancing-act-main.js as an example.

In order to potentially identify any major design or implementation issues relatively early in the development cycle, PhET is starting a review of this simulation's code as it exists today. Minor issues will be noted in the simulation with the "//REVIEW" marker, larger issues will be logged separately and linked to this one.

To duplicate: Play part of a level (doesn't matter which operation type or level), return to the level selection screen by pressing the star button, go back to the same level, press the refresh button so that the board is cleared, then press the return to level selection (star) button. The progress indicator with still be partially filled in.

During a review on 6/20/2014, @dubson requested that the feedback faces (i.e. the smile and grimace faces) should fade out instead of simply disappearing. This was how the correct answer feedback worked on the original simulation.

Fading can be implemented using a timer and setting opacity.

If the timer is off, the time indicator should not appear in the scoreboard panel. The score should be vertically centered below the 'refresh' button.

When testing with assertions enabled (i.e. using the ?ea query parameter), an assertion occurs due to setting the text in a Scenery Text node to an undefined value. This is occurring because the default values for the properties in GameModel are all undefined, so resetting them causes this assertion. The default values probably need to be something else.

To duplicate, run the code as of SHA 672bb25 (the most recent as of this writing) with the ?ea query parameter.

When working on the Factor screens, the numbers on the edge of the board don't highlight. They should do so, and should use the same colors as they do on the Multiply screen.

This can be reproduced on this snapshot:http://www.colorado.edu/physics/phet/dev/html/arithmetic/1.0.0-dev.5/arithmetic_en.html.

The grid lines start to overwhelm the screen when the grid is larger. On the original simulation, the lines are made thinner when there are more numbers on it. It's a subtle but important effect. Screenshot below illustrates the issue.

...and here is a screenshot from the original Flash simulation:

Please rename Constants.js to ArithmeticConstants.js. With so many simulations, the names need to be more specific so that we can easily find the needed files. This should be done for all sims going forward.

When using the factoring mode, click on the correct square, and there is enough delay before the number appears that a different square can be selected. See screenshot below.

To capture this screen shot, I clicked on the correct square, then moved the mouse fairly quickly.

The level selection screen, as of v1.0.0-dev.3, looks like this:

In order to match PhET conventions, and just look better, the sound and time control should be on the left and should use the default yellowish color. Here is an example screenshot from BalancingAct:

zero cannot be put into input zone - after trying to put it it is impossible to use any other number instead

In version 1.0.0-dev.3, the 'Enter' button on the keypad starts out yellow and looking somewhat disabled, then turns white when enabled. It should turn yellow when enabled. I suggest using the disable capability of RectangularPushButton.

See http://www.colorado.edu/physics/phet/dev/html/arithmetic/1.0.0-dev.3/arithmetic_en.html to duplicate.

The captions don't appear on the nav bar for the 3 screens. This was probably done because the icons already contain the words (i.e. Multiply, Factor, and Divide), so the captions would be a bit redundant. However, the nav bar looks weird without them. It would be better to go ahead an include them, and add small icons for the nav bar that exclude the words.

The constants file (called Constants.js as of this writing) is in common/model/, but there are constants that relate to the view here as well. It should be moved up to the parent directory, i.e. common/.

In the current version (SHA 3096612), the smiley face is present immediately upon starting a level, before entering any values. See screen shot.

There are common code strings in the "Vegas" repo that can be used for displaying time and score on the control panel, please see vegas-strings_en.json. The layout won't be quite as nice, but they will be easier to translate and will work better for right-to-left languages, so PhET has decided that we should go ahead and use them.

This is a change to the originally specified behavior, and as such should be estimated by MLL.

Currently, if the user returns to the level selection screen by pressing the Return to Level Selection button (the one with the star on it), any work that had done is lost. The design team has decided that it would be better if the work was retained, so that the user could go back to a partially completed level and pick up where they left off, even if they start on a different level. This would imply maintaining separate state information for each of the 3 levels for each of the screens.

If the user plays part of the game, then returns to the level selection screen, their score should be indicated in the progress indicator in the level selection buttons. Right now, the buttons indicates no progress if the level wasn't fully completed.

When adding the 'dev' query parameter to the URL, there should be a red rectangle (added by joist) that shows the 'safe' area of the screen. You can see it on the home screen, but it's missing on the individual screens. You're probably doing something to remove it or obscure it.

Look at scenery issue #233.

Again this is only occasional; I have noticed it on about every operating system using Firefox. It only appears on the initial opening of the simulation. After reloading the issue is not present.

Chrome 35.0.1916.153

Firefox 30.0

Safari 6.0

The factor portion of the simulation will stop functioning and the buttons for a certain number will become unusable. Tested on OSX 10.8 Chrome 35.0.1916.153

Steps to reproduce
-Click the factor portion of the simulation
-When the product of the equation is displayed, click the number UNDERNEATH the correct answer. This is the best way to reproduce this issue.
-After getting the answer incorrect, click the same number again and drag the cursor to the correct answer
-Try clicking the correct answer after this attempt. The button for the correct answer will become unusable and the user will not be able to progress.

Some changes to the color scheme were made to the spec on June 2, 2014 (according to the Google Doc revision history). This is a change to the specification from the original version that MLL quoted, so MLL should estimate the cost of these changes and PhET will determine whether MLL should do them or if they will be done internally.

On lines 94 through 96 of ArithmeticModel.js (as of SHA 9dd2e69) it looks like a reset occurs when the level is changed to some falsey value (maybe null or undefined?). This seems like an indirect and potentially confusing way to reset the model. It would be better if there were a specific and clear reset method.

Once a user has started a level, the timer should continue to run if the user exits the level. Currently, if the user starts working on a level and then goes back to the level selection screen, the clock stops and then starts running again when they resume the level.