phetsims / area-model-decimals Goto Github PK

The width of the partially hidden Area Model Calculation box (The middle option) changes when dragging the partitions. While the max width is changeable to allow for very large calculations, similar uses in the Area Model suite, or even the fully visible Area Model Calculation option, seem to have the width set at the width of the graph.
Found while working on phetsims/qa#201, but unrelated as it appears in Win 10 as well.
Steps to reproduce:

1. Go to Area Model Decimals
2. Go to the 2x2 or 3x3 scene
3. Drag the area so it is larger than 1x1
4. Select the partially hidden Area Model Calculation box
5. Drag a partition back and forth, making sure it crosses a spot where one of the partitions = 1.

Example on partially hidden box:

Example on fully visible box:

@jonathanolson looks like I can only repro this in this sim, so maybe floating point errors?

1. Set up your horizontal area to have a left partition that is > 0.1 and < 0.6, like:

2. Using the pickers in the Dimensions panel (NOT the partition drag handle), decrease the horizontal area (slowly) until the right edge meets the partition line.

Usually the partition line would "snap" to the far edge when encountering an area of 0, but in this case it stays:

Seen on 10.13.3 Chrome, master at 3:00 PM (3/16).

The calculation panel needs some description work. The calculation could be hidden, show line-by-line, or show full calculation.

Description questions:

1. How should we organize this content? Should we make "H3: Calculation" and under that list the radio button group AND the panel?

Implementation questions:

1. In line-by-line mode, there is a set of up/down buttons that allow you to "scroll" through each line of the calculation. Do we implement these as buttons? Or is there a native html scroll element that we can leverage?

I'll add to the above as I think of my questions.

Per @kathy-phet's request in phetsims/qa#295 I am making issues in each published sim repo detailing the pointer areas and usability of sims on phone sized screens. Done on an iPhone 7 iOS 12 device.

Potential Difficulties Noticed:

• None seen

Screenshots:

Although the area-model-introduction draggable node seems to work just fine, I get an assertion error when trying to use the arrow keys to change the grid size for the decimals sim. @jonathanolson do you know how this regression could have happened.

Design

• Sim folder and design doc created (Date: //)
  • Create sim folder in PhET Sim Design Folder using phet-docs account
  • Place design doc in the sim folder
• Sim suggestions doc reviewed
• Learning goals and standards identified (Date: //)
• Design concept complete (Date: //)
• Wireframes complete (Date: //)
• Mockups complete (Date: //)
  • Mockups checked for colorblind and greyscale
• Features for PhET-iO discussion
• Interviews complete (Date: //)
  • Results reported to team
  • Notes pasted into design doc
  • Back-up of interviews
• Lead designer "sign off" (Date: //)
  • Performance acceptable
  • Carefully review ?showPointerAreas
  • No new feature requests
• Pre-publication items
  • Auxilary screenshots (up to 3 additional)
  • Accessories (keywords, categories, description, learning goals, related sims, NSDL)
  • Teacher Guide created, uploaded, and added to sim design folder
  • Add an activity
  • Sim primer draft
• Post-publication items
  • Add to Edmodo
  • Add to Gooru (signed in as phethelp)
  • Sim primer (create issue, publish ideally within 1 month of live sim)
  • Hold postmortem if applicable (Date: //)

Implementation

• Repository created (Date: 01/12/2018)
  • Simulation added to responsible_dev.md
  • simula-rasa used to create project skeleton
  • README.md created using grunt unpublished-readme
  • Collaborators added (such as QA team, designers, etc)
  • standard GitHub label set applied
  • repository added to perennial/data/active-repos (then grunt generate-data in perennial and check in)
• Development started (Date: 01/12/2018)
• Sim is "feature complete" (Date: 01/12/2018)
• Code review completed (Date: //)
• Pre-publication items
  • Main screenshot (2048x1344, PNG, 32-bit color, browser chrome stripped)
  • Verify credits
• Published (Date: 4/24/2018)
  • README.md updated using grunt published-README (in master and release branch)
  • Mark the sim as published in responsible_dev.md

QA

• Dev testing started (Date: //)
• Dev testing completed (Date: //)
• First RC published (Date: //)
  • Test matrices put in Testing Matrices Folder
• RC testing completed (Date: //)

This branch (1.2) had changes related to the following applied:

• fix for iOS 13 Full Screen, see phetsims/phet-core#64
• phetsims/scenery#1006

Presumably one or more of these changes is likely to have been applied after the last RC version, and should be spot-checked by QA in the next RC (or if it was ready for a production release, an additional spot-check RC should be created).