phaxio / phaxio-php Goto Github PK

The Phaxio API states that for the faxList request, both the start and end timestamps have default values (-1 week, and now). It should be possible for the client to take advantage of these defaults by not passing values for them.

In particular requiring an end timestamp seems like a trap for the developer. I wanted all available updates, and would have happily taken the phaxio's server's default for "now". But since I was forced to pass a value, I used time() on my local machine. Well it turns out the clock on my dev box VM had drifted a couple minutes, such that the end timestamp I was passing was inadvertently excluding the most recent updates. I fixed that problem for now by passing time() + 15 minutes instead but ideally I shouldn't have had to worry about this.

Currently delete() only allows deleting fax records, not just the files.

Is it an idea to tag the current stable (?) release? Installation using Composer currently requires:

"phaxio/phaxio": "dev-master"

This would cause changes to be immediately be adopted when they are committed to the master branch, which might not be preferred on production environments. Something like:

"phaxio/phaxio": "0.1.0"

Or

"phaxio/phaxio": "~0.1"

Would be preferred.

Also see https://getcomposer.org/doc/01-basic-usage.md#next-significant-release-tilde-operator- and the part about semantic versioning :)

Need to start using CURLFile and have backwards compatibility for PHP 5.6+. See this: http://stackoverflow.com/questions/25934128/curl-file-uploads-not-working-anymore-after-upgrade-from-php-5-5-to-5-6

Hello,

it seems that last release was done long time ago. Are you planning any other releases soon? It seems that there are some useful fixes in master branch such of test_fail param support. However I would not prefer using dev-master on production

I guess this would be a pain to be compatible with v1 also, but a breaking 2.0.0 release that only works with v2 of the API would make sense to me.