phar-io / filesystem Goto Github PK

The creation of a PharIo\FileSystem\Directory instance create the directory if it didn't exists.

It's cause by:

It can be problematic in the some case like this one for example:

$file = new PharIo\FileSystem\Directory(getcwd())->child('not_existing')->file('a_file.txt');
if ($file->exists()) {
    echo 'Yes!';
} else {
    echo 'Something wrong';
}

References: phar-io/phive#179, phar-io/phive#233 (comment)

Possible solution

Only call $this->ensureExists($path); when we do a write operations:

• \PharIo\FileSystem\Filename::putContent
• \PharIo\FileSystem\File::saveAs

This will imply to do more check in \PharIo\FileSystem\Filename and \PharIo\FileSystem\File whenever the parent directory exists or not