phar-io / composer-plugin Goto Github PK

$ bin/composer.phar phive:run
Phive requires PHP 7.2 or later; Upgrading to the latest version of PHP is highly recommended. 

Even though I Composer require-dev "phar-io/composer-plugin": "^0.1.2" which requires "php" : ">=5.6.0", I am getting the latest phive version which requires php 7.2.

I can see that in my vendor/phar-io/composer-plugin/bin/phive.phar/.phar/stub.php there is new StaticPhiveVersion('0.14.4') fragment which confirms, that the latest phive phar is being downloaded, not the version specified by the composer-plugin.

More info about the problem: phar-io/executor@ddf26ba#r42344083

The Phive command should not try to interpret the arguments provided for Phive, but instead handle them as a single string.

Hi guys,

here are the first plan to build the plugin. I see the two major parts "Installer" and
"Commands" in there. And i'm also add some off topic points.

The installer

Here is the biggest question. How we want to install phive? There are two options for me
with pro's and con's.

Option one - use source

PRO

• Just a requirement in the composer.json. (Actually no Packagist entry are existed)
• phive itself has few requirements. So the overhead for composer is insignificant.

CON

• Selfupdate is a little bit tricky, but possible with a virtual composer-package for example. And we need selfupdate! The most developers will install this plugin in global scope. And nobody updates plugin's in global scope. ;-)
• No GPG verification for phive itself

Option two - use the PHAR file

PRO

• Selfupdate are simple
• GPG verification are possible

CON

• An advanced installer must be implemented. Composer has all the magic on board to download phive. The steps for GPG verification must be implemented.

The commands

I will implement a CommandProvider which contains the following phive commands:

• version
• list
• install
• purge
• remove
• reset
• (selfupdate)
• skel
• update
• update-repository-list
• check (internal "composer")

These commands are only adapters to the real commands with prepared parameters.
So for example the install command gets the prepared target path to the composer binary directory

I would also implement a show command which will output a table of the current used PHAR files (content of the phive.xml file) in project.
The "check" command are mapped to the internal "composer" command because of naming conflicts.

All commands get the prefix "phive" in the CLI. So they are grouped by default.
That means under available commands in the Composer CLI there are:

...
why
why-not
phive:
   	install
   	list
	...

So an example command call looks like this: composer phive:install phpunit.

Off topic

The minimum supported PHP version are "5.6.x".
For testing PHPUnit are used.

Open questions

• Which installation option we would like to use?
• Do we want a check on a specific event, like install or update, to compare phive.xml with the composer vendor binary path? For example to load/add the required PHAR file(s) by project initialization.
• Did i forgot something? Or did you need an advanced plan?

The problem is that the Composer binary which comes via Homebrew always add "--ansi" or "--no-ansi" to all commands. But in this special case for us, the parameters are in the wrong order. See here.

Maybe we should use the bin-dir from Composer by default as the target directory for installed phar's.

What are you think @theseer, @belanur? I would it prefer.

Are there plans to update this to work with Composer 2?