pgrimaud / action-shopify Goto Github PK

Using the arg as mentioned in the readme:

      - name: Shopify
        uses: pgrimaud/action-shopify@master
        env:
          SHOPIFY_PASSWORD: ${{ secrets.SHOP_ACCESS_TOKEN }}
          SHOPIFY_STORE_URL: ${{ secrets.SHOP_STORE }}
          SHOPIFY_THEME_ID: ${{ secrets.SHOP_PULL_THEME }}
          THEME_PATH: ${{ secrets.THEME_PATH }}
        with:
          args: --directory=dist

Getting error: unknown flag: --directory

theme-kit recently made this --allow-live flag required for pushing changes to live themes.

Then production builds using this action now fail with the following error:

[development] This is the live theme on <store>. If you wish to make changes to it, then you will have to pass the --allow-live flag

A solution for this would be either:

• to lock the used theme-kit version
• or to add this flag here

What do you think @pgrimaud?

(Btw, thanks for this amazing GH action 💯 )

Hello,

I have a couple of workflows running using your action but something really weird started to happen in the last ~18hrs: all action runs fail with the following error: Docker build failed with exit code 1.

Specifically, it fails when importing this python module:

Any ideas?

I am seeing an issue where the shopify action is not able to find the checked out theme. Below is a slim example of the action file:

jobs:
  # This workflow contains a single job called "build"
  build:
    # The type of runner that the job will run on
    runs-on: ubuntu-latest

    # Steps represent a sequence of tasks that will be executed as part of the job
    steps:
      # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
      - uses: actions/checkout@v2

      - name: Deploy Shopify theme
        uses: pgrimaud/[email protected]
        env:
          SHOPIFY_PASSWORD: ${{ secrets.DEV_SHOPIFY_PASSWORD }}
          SHOPIFY_STORE_URL: ${{ secrets.DEV_SHOPIFY_STORE_URL }}
          SHOPIFY_THEME_ID: ${{ secrets.DEV_SHOPIFY_THEME_ID }}
          THEME_PATH: /github/workspace

Error: readAsset: open /github/workspace/***: no such file or directory

Regardless if I use /github/workspace, ./, $GITHUB_WORKSPACE, or ${{ github.workspace }} for the THEME_PATH it appears that the theme is in accessible by the themekit instance.

Hello, we are having issues when making changes to the theme customizer.

Since settings_data.json is modified, we are having trouble merging the changes together, since Shopify is so picky about the formatting of settings_data.json. The deployment then fails because of this.

What's the best way to approach this? We have thought of simply deploying it without settings_data.json and then making the required changes again on the theme deployed to.

Many thanks.

Hi and thanks for this wonderful and puch needed action to deploy to shopify using github and in a clean way.

I am starting to work on shopify and coming from more framewokrs like node and Rails, having to copy/paste/replicate in shopify code editor theme as they usually advice seems a very poor dev experience.

That's why I found your action very exciting + useful !

I have a question as a non expert of github actions and workflows.

It seems i can't seperate environements on shopify: if i push with github actions changes to shopify theme, it will become the "live" version immediately and i can't check on a fake/branch/staging website that the changes actually work.

Effectively you'd have 2 stores on shopify: one "live" for the public and one called "staging" or "dev branch" ...

So my idea was: would it be possible to add 2 sets of environments variables :

• one called Variables store staging/feature branch (SHOPIFY_PASSWORD, SHOPIFY_STORE_URL...) that would be like the staging/dev mode: you create a branch on github to create a feature X (for example: branch https://github.com/misner/myproject/pull/65), and if you commit any file on github on ANY branch (which is not the MASTER), then this will trigger the deploy to a store Staging . This way, you can dev safely knowing your changes won't affect the production store.
• another called Variables store Production (SHOPIFY_PASSWORD, SHOPIFY_STORE_URL...) that would be like the prod/live mode: if you commit any file on github this will trigger the deploy to a store meant to play the role of the production. In this case, the deploy only happens to the **production store" on shopify if you click on Merge Pull Request, that is to say if you merge with Master on your github repo

I'm self trained to CI/CD dev, rails,... and starting only now shopify dev, and never wrote any workflow on github actions as well. So maybe it's a bit unclear so tell me if this makes sense?

Tell me what you think.

thanks a lot!