Code Monkey home page Code Monkey logo

bribes_module_speed's People

Contributors

petrovska-petro avatar

Watchers

avatar

bribes_module_speed's Issues

explicitly test successful signing of cowswap order

bribes_module_speed/tests/test_bribe_swap_for_weth.py

Lines 145 to 149 in e32551c

speed_module.checkTransactionAndExecute(
bribes_processor.address,
data,
{"from": executor},
)

does IGnosisSafe(safe).execTransactionFromModule return something on successful execution?

i guess the require here assures that it runs successfully,

bribes_module_speed/contracts/SpeedScopedModule.sol

Lines 138 to 146 in e32551c

require(
IGnosisSafe(safe).execTransactionFromModule(
to,
0,
data,
IGnosisSafe.Operation.Call
),
"exec-error!"
);

but an explicit test would be nice maybe.

(it is a tough situation, because the signature happens on fork and therefor never changes the api state)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.