issue come from master branch but very visible in webpack2-hrm branch

Steps to reproduce

1. set your NODE_ENV to development
2. run npm run start:dev
3. kill it and run npm run build:server and npm run start .
4. Notice env still set to development. build does sets NODE_ENV to production but it does so after build:server in prestart
5. open localhost:3000 with network - watch /__webpack_hrm request.

Expected
Manage node_env more consistent.

Suggestion

  "prestart": "rm -rf compiled && npm run build:server && npm run build",
  "prestart:dev": "NODE_ENV=development npm run build:dev",
    "build": "NODE_ENV=production webpack --config src/config/webpack.config.prod.js --optimize-minimize",
    "build:dev": "NODE_ENV=development webpack --config src/config/webpack.config.dev.js",
    "build:server": "NODE_ENV=production webpack --config src/config/webpack.config.server.js",

Since you guys rolled out all these different options, it would be great to see load time comparisons in order to see how they each perform independently (bundle.js, css, etc)

Thank you and great work

I am new to webpack, and to github, so if this is not the right area to ask this question then please point me in the right direction.

I must have some sort of config issue on my side with babel. I cloned the react-hot-loader branch, and when I run the start:dev script, npm gets to the build:dev script I get a Syntax error:

/react-lego/src/config/webpack.config.dev.js:4
const { SRC } = require('./paths');
      ^ 

Any idea what I'm doing wrong?

some unit tests are failing due to Enzyme not being compatible

Hi Peter, thx for this awesome repo! I'm currently working on an implementation of server-side rendering and your guide at: https://github.com/peter-mouland/react-lego/wiki/Redux-Promise-Middleware helped a lot.

I've stumbled upon an issues using sync routes however and I'm curious if you have any insights on the following scenario:

1. Render app component and fetch data on the server side using the needs construction
2. App component generates routes based on fetched data
3. Generated routes point to new component that also have data needs (which I would like to render on the server)

With your current solution only the data needs for the app component are resolved on the server because the data needs of sub components become available after the resolve of the initial data. At this point the server already returns because it doesn't know about new data needs.

What are your ideas about this?

Hi,
I noticed that when I tried to run npm run build:server on the css-modules branch, it breaks and that does not allow me to do a good npm run start. I think that the reason this is happening is related to this issue with css-modules/css-modules-require-hook#67. I'm working on trying to see if I can fix it, but maybe someone who knows this stuff better may be able to give me a helping hand on this.

#30

http://react-toolbox.com/#/components

https://github.com/mobxjs/mobx
https://www.youtube.com/watch?v=Aws40KOx90U

todo:

• archive an origin react lego into react-lego-2016 repo.
• refactor base client-side app to use latest versions.
• remove old branches that demo upgrade paths.
• mention react-lego-2016 in readme to help point people to old upgrade examples.
• remove express branches (koa v2 ftw) as there are plenty of express examples.
• update wiki
• ensure lego 2017 focuses on dev experience and and perf

Thanks for rr4 branch.
I encountered an error if use MemoryRouter in server render cycle. See remix-run/react-router#4076 (comment)

Due to this https://github.com/peter-mouland/react-lego/blob/webpack2-rhl-rr4/src/app/Root.js#L11

I'm not sure what the popularity of this is like, but I was thinking that maybe we can include a firebase branch as well, either branching off from universal(for server side rendering) or the master branch (for client side only).

from a clean clone of branch webpack2-rhl.

node --version
v6.3.0

npm --version
3.10.7

When i try to start, I am getting error here DEBUG=lego:* on windows, anyway i removed that tested all features.

One more question, where is the branch which has all integrated? your master branch is not having the redux integrated.

Thanks.

webpack-dev-server 1.14 requires webpack 1.

webpack-dev-server now has 2.1.0-beta.8 that support webpack 2.
Note: there are breaking changes in beta3

Also "purifycss-webpack-plugin": "^2.0.3", required webpack 1

they currently fail due to not being updated after upgrading react-router

building an all singing Koa-app, but implimenting react-router-addons-routes (to help with server-side data fetching with react-router-v4) causes the api return to 404.

Think the generators of koa are to blame, not the above plugin...

when making changes to front-end app we see the following error:

browser.js:49 Warning: [react-router] You cannot change <Router routes>; it will be ignored

Hey,
So I noticed this is not really an issue of sorts, but I'm not really sure if its a quick fix or not. I want to be able to use es6 code in my server-side. That means, all that fancy spread operators, imports, etc...
I noticed if I do that, when I try to do an npm start, it will fail because it won't recognize those es6 syntax. We can set it up maybe so it transpiles down first and then webpack will pick it up.

Hey, I think this is an isomorphic webpack issue. I noticed that npm start( which does the compilation for the server build) fails for the svg branch. Not exactly sure the issue and was wondering if you can look into that.

koa-app is an almost complete branch... just needs promise middleware for async server data fetching before render.

maybe use: https://github.com/ReactTraining/react-router-addons-routes

after updating to nodemon on the dev server, the e2e tests no longer automatically shut down.

note: also affects webpack2-rhl branch

 lego: Environment: { DEBUG: 'lego:*', NODE_ENV: 'development', PORT: '3000' } +0ms
  lego: server-entry ReferenceError: React is not defined
    at Object.<anonymous> (/Users/ngoctranfire/Desktop/react-lego/src/app/containers/Game/assets/chevron.svg:1:1)
    at Module._compile (module.js:541:32)
    at loader (/Users/ngoctranfire/Desktop/react-lego/node_modules/babel-register/lib/node.js:144:5)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/ngoctranfire/Desktop/react-lego/node_modules/babel-register/lib/node.js:154:7)
    at Module.load (module.js:456:32)
    at tryModuleLoad (module.js:415:12)
    at Function.Module._load (module.js:407:3)
    at Function.Module._load (/Users/ngoctranfire/Desktop/react-lego/node_modules/isomorphic-loader/lib/extend-require.js:79:29)
    at Module.require (module.js:466:17)
    at require (internal/module.js:20:19) +801ms

This error appears when I try to run npm run start:dev in the svg-isomorphic-loader branch. I think this is an outdated branch, and the svg branch is probably the one we should be using. If that is correct, we can just close this issue.

• Fork / Retire / start a new React Lego
• React 16
• Webpack 4
• Babel 7
• Use CSS Custom Props over sass variables
• use my own custom BEM helper
• Switch to Jest for code-coverage ease
• Manually include required poly-fills to reduce bundle-size (and write up!)
• Compare redux with redux-zero
• Show how to create and re-use a shared vendor bundle
• compare vanilla GraphQL with Apollo
• spike perf testing
• create separate bundles w/ ctm test for es modules
  • ...perhaps a separate project, show how to combine many lego-kits

See gaearon/react-hot-boilerplate#97 (comment)

it looks like react hot reloader is dead. In a good way. Btw really great project 👍

Sorry to be filing so many bugs and such, but I really like your project and its actually helped me to learn redux by the pieces and get to understand the numerous moving parts that are so confusing to me.
On your react-hot-loader branch, just by itself, I noticed that it just doesn't work correctly. When I make a change, the changes are not updated automatically. Also, I was getting this error at the beginning: not sure if it's related.

HMR] Update check failed: Error: Manifest request to /6a46934f57636f62dc58.hot-update.json timed out. at XMLHttpRequest.request.onreadystatechange (http://localhost:3000/app.js:34:23)

Hey, so I noticed that in the webpackv2 branch, we don't actually have the package.json updated. It is still webpack 1.13 I believe? I believe we have to update it manually.

branch off redux-dev-tools

Possibly using https://github.com/reactjs/react-router-redux

see #23

using webpack 2 + react router 4

https://twitter.com/addyosmani/status/780830460523913216

I'm currently using Meteor for both client and server builds. However with the activity and movement around GraphQL, I believe it could be a very viable option to opt for a client-only build without involving Meteor at all on the client. I also think this would speed up development by using webpack and getting out of Meteor's slow build process.

Any possibility of adding a sample GraphQL item to your list? Can use the just released GitHub GraphQL API for a sample: https://developer.github.com/early-access/graphql/

I also wonder how this would affect Redux (if at all).

btw I LOVE LOVE LOVE this repo! So many great examples.

related to : bahmutov/node-hook#6 (comment)

For the server-side code compilation, babel-cli makes less code changes compared to webpack. I think babel would therefore be preferable over webpack.

I'm not super sure, but I took a look at the set-router-context.js and actually tried setting this up with my own project, but I noticed that it looks like the routes we are passing into the match() function does not have a history object, and a route that has correctly been synced with the redux store.