peter-gribanov / analyzertext Goto Github PK

see https://scrutinizer-ci.com/g/peter-gribanov/AnalyzerText/issues/master/files/AnalyzerText/Analyzer/Frequency.php?orderField=path&order=asc&honorSelectedPaths=0&issueId=39980759#inspectioncomment-132555578

The expression $this->percent of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

Пример

$analyzer = new Frequency();
$analyzer->setText(new Text('Петрович ударил со всей силы кулаком по столу'));
$analyzer->applyFilters()->Informative();

Undefined offset: 4

/mnt/c/www/AnalyzerText/AnalyzerText/Text.php:60
/mnt/c/www/AnalyzerText/AnalyzerText/Filter/Factory.php:97
/mnt/c/www/AnalyzerText/AnalyzerText/Filter/Factory.php:43
/mnt/c/www/AnalyzerText/tests/Filter/FactoryTest.php:89

see https://scrutinizer-ci.com/g/peter-gribanov/AnalyzerText/issues/master/files/AnalyzerText/Filter/WordList/WordList.php?orderField=path&order=asc&honorSelectedPaths=0&issueId=39980756#inspectioncomment-132555576

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

https://github.com/neonxp/Stemmer
https://github.com/wamania/php-stemmer
https://yandex.ru/dev/mystem/

Пример

$analyzer = new Frequency();
$analyzer->setText(new Text('со всей силы'));
$analyzer->applyFilters()->Informative();

OutOfBoundsException: Seek position 2 is out of range

/mnt/c/www/AnalyzerText/AnalyzerText/Filter/WordList/WordList.php:89
/mnt/c/www/AnalyzerText/AnalyzerText/Filter/Informative.php:59
/mnt/c/www/AnalyzerText/AnalyzerText/Filter/Factory.php:97
/mnt/c/www/AnalyzerText/AnalyzerText/Filter/Factory.php:43
/mnt/c/www/AnalyzerText/tests/Filter/FactoryTest.php:89