Code Monkey home page Code Monkey logo

Comments (9)

jacobtomlinson avatar jacobtomlinson commented on August 20, 2024 1

Awesome! Again, thank you for your work here!

from create-pull-request.

jacobtomlinson avatar jacobtomlinson commented on August 20, 2024 1

So it's best to delete the branch after you merge or close the PR.

I hadn't thought about that. I'll be sure to do that. I may even set branches to be automatically cleaned up.

from create-pull-request.

matfax avatar matfax commented on August 20, 2024

I'm facing a similar use case.
Maybe try branch-suffix: none for the start. That should prevent the duplicate PRs.

from create-pull-request.

peter-evans avatar peter-evans commented on August 20, 2024

@jacobtomlinson I think your use case fits Strategy B - Create and update a pull request branch.

As @matfax suggested, if branch-suffix is set to none it will create the pull request branch if it doesn't exist and then any subsequent changes will be updated to the same branch name.

from create-pull-request.

jacobtomlinson avatar jacobtomlinson commented on August 20, 2024

Ah ok! I saw this line

Any subsequent changes will be committed to the same branch and reflected in the existing pull request.

and assumed it would only raise a single pull request. If I merge the pull request and then new commits are added is another pull request raised?

from create-pull-request.

peter-evans avatar peter-evans commented on August 20, 2024

Yes, if you merge or close the pull request another one will be created.

I will revise the wording of that sentence and make it clearer.

from create-pull-request.

jacobtomlinson avatar jacobtomlinson commented on August 20, 2024

Another quick question. If the repo uses "squash and merge" for it's merging strategy will this cause problems with using a single branch?

from create-pull-request.

peter-evans avatar peter-evans commented on August 20, 2024

I don't think so. The only possible problem right now is that there is no rebase feature. So it's best to delete the branch after you merge or close the PR. I'm thinking about adding a rebase feature so this won't be a problem.

from create-pull-request.

jacobtomlinson avatar jacobtomlinson commented on August 20, 2024

Looks like this has been resolved in 6342438.

from create-pull-request.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.