Comments (9)
Awesome! Again, thank you for your work here!
from create-pull-request.
So it's best to delete the branch after you merge or close the PR.
I hadn't thought about that. I'll be sure to do that. I may even set branches to be automatically cleaned up.
from create-pull-request.
I'm facing a similar use case.
Maybe try branch-suffix: none
for the start. That should prevent the duplicate PRs.
from create-pull-request.
@jacobtomlinson I think your use case fits Strategy B - Create and update a pull request branch.
As @matfax suggested, if branch-suffix
is set to none
it will create the pull request branch if it doesn't exist and then any subsequent changes will be updated to the same branch name.
from create-pull-request.
Ah ok! I saw this line
Any subsequent changes will be committed to the same branch and reflected in the existing pull request.
and assumed it would only raise a single pull request. If I merge the pull request and then new commits are added is another pull request raised?
from create-pull-request.
Yes, if you merge or close the pull request another one will be created.
I will revise the wording of that sentence and make it clearer.
from create-pull-request.
Another quick question. If the repo uses "squash and merge" for it's merging strategy will this cause problems with using a single branch?
from create-pull-request.
I don't think so. The only possible problem right now is that there is no rebase feature. So it's best to delete the branch after you merge or close the PR. I'm thinking about adding a rebase feature so this won't be a problem.
from create-pull-request.
Looks like this has been resolved in 6342438.
from create-pull-request.
Related Issues (20)
- Unable to create new PR from old branch HOT 1
- unable to create pull request due to cherry-picker error HOT 1
- Pass parameters to commit
- Request: Document PAT permissions requirements for machine accounts HOT 2
- `push-to-fork` won't push to sibling repos in the same network HOT 3
- add a no-verify option HOT 1
- Support commenting on a PR when closing it HOT 4
- PR is geeting auto merge HOT 1
- Commit author is `web-flow`? HOT 3
- Fine-grained PATs will also work HOT 2
- Upgrade action to use node20 HOT 4
- Commit message not updated when PR is updated HOT 1
- Actions not triggering even with Custom App HOT 6
- Photo from Tajdoost
- stale info error when specified branch doesn't exist but a tag with the same name exists HOT 2
- Add no-verify option because rm -rf .git/hooks doesn't work HOT 2
- Github Action is not working HOT 1
- This isn't recognizing changes between two branches of two repos HOT 2
- using with git-crypt HOT 4
- Is it possible to fully restore all git state after the action? HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from create-pull-request.