Comments (5)
Hi @glasser
Thank you for reporting this issue.
I added the add-paths
feature in v3 and the stash and restore in v5. When I added those features I didn't fully consider that it would make the action a bit inconsistent in the way that it leaves git state. The stash/restore is only used when add-paths
is specified. For some state like git config/auth I've made an effort to revert all changes and leave the state as it was found. I think perhaps it makes sense to try and do that consistently for all git state.
I don't really want to add additional options to the action, unless it's unavoidable. I've made an effort to keep the interface simple and not bloated with config options. So I think reverting all state in every case is simple and intuitive.
I'll take a look at this change when I get a chance. It would require a major version bump, though, because potentially it would be a breaking change for some workflows that expect a particular git state after the action completes.
from create-pull-request.
I would certainly be happy if v6 let me do the thing I wanted with zero extra configuration :)
from create-pull-request.
I remember now why the non-config git state works this way. One of the features of this action is that you can make your own commits which get included in the PR. I think it's a bit too complicated (and probably undesirable) to try and restore those commits after the action completes, so I decided to just let the git state reflect anything that wasn't committed by add-paths
.
I think I would prefer to leave it the way it is for now. I might change my mind in future.
There is a pretty straightforward workaround, as an alternative to the one you are already doing. Just run the Create Pull Request for all
step in a separate job in parallel.
from create-pull-request.
Makes sense. The downside to parallelizing is that constructing the file changes can be slow, so ideally that is shared across jobs. Though GH Actions does provide various ways to share state across jobs...
from create-pull-request.
Closing for now.
from create-pull-request.
Related Issues (20)
- Using environment variables in `body-path` file HOT 1
- bit
- I'm confused what the `base` option is supposed to do HOT 1
- Don't require a deep fetch for forks HOT 11
- Token generated from GitHub App not working with push-to-fork HOT 4
- Default to "Squash and Merge" HOT 1
- I get error "protected branch hook declined" when I try to create a draft pull request into protected branch HOT 1
- Force update the branch of existing pull request HOT 1
- Empty PRs being created, is this expected? HOT 4
- Error creating new PR HOT 2
- `title-path` and `commit-message-path` inputs HOT 1
- `base` also does a checkout to that branch HOT 1
- Update multiple repositories HOT 2
- ignore untracked HOT 2
- NO PR created and branch changes to new branch and updates from main HOT 5
- Required checks are not being triggered after the PR creation HOT 1
- Error: Input 'token' not supplied. Unable to continue. HOT 1
- Changes from test folder doesn't added to the PR HOT 10
- Node version - Warning HOT 1
- Permission denied (publickey) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from create-pull-request.