petdr / vide Goto Github PK

On Delphi 10.1 Berlin (24.0.22858.6822) with the latest version from this repository, insert mode works as expected. On normal mode, when clicking "j" to move the cursor down one line it in fact goes down one line, but also inserts a "j" in the cursor position, the same with other keys ("w" moves a word forward but also inserts a "w", etc), as if it was both on normal and on insert mode.

When in insert mode, if I type a single quote ' using a us-international keyboard, the char is added twice.

I noticed that the cause is this code: https://github.com/petdr/vide/blob/master/Source/ViBindings.pas#L455

else if not ((ssCtrl in Shift) or (ssAlt in Shift)) then
    begin
      GetKeyboardState(keyState);
      ToAsciiResult := ToAscii(Key, ScanCode, keystate, @c, 0);
      // XXX do we handle the case of two characters in the buffer?
      if (ToAsciiResult > 0) then
      begin
        if (Key = VK_BACK) then
          SetLength(FInsertText, Length(FInsertText) - 1)
        else
          FInsertText := FInsertText + c;
      end;

If I remove this, everything works fine, as this code is only executed in insert mode.

The question is why is this code needed? Can't we just let Delphi handle the insert mode?