perbu / dgram Goto Github PK

internal variable: self.max_packet declared in class UDPServer is never used.

Probably instead of:
buf, addr = s.recvfrom(MAX_PACKET_SIZE)
should be:
buf, addr = s.recvfrom(self.max_packet)

Hi @perbu,

Thanks for making this code available to the world. I saw that you closed your issue in micropython after nobody responded for a while. That's a shame because it seems that this functionality is missing in micropython and relatively hard to stumble across on one's own.

My understanding of uasyncio is limited but it seems like your work here could be the beginning of loop.create_datagram_endpoint() support. Would you agree?

Please consider re-opening your issue with micropython. I'd be happy to do what I can to help get some traction on an issue.

Regards!

Should be:

from dgram import UDPServer
import uasyncio

port=12345

def cb(msg, adr):
    print('Got:', msg)
    return 'ack'.encode('ascii')

def main():
    s = UDPServer()
    l = uasyncio.get_event_loop()
    l.run_until_complete(s.serve(cb, '0.0.0.0', port))

Then it would work without changes.

it should be
except uasyncio.core.CancelledError:
instead