Code Monkey home page Code Monkey logo

peopledatalabs-go's People

Contributors

dependabot[bot] avatar eliskovets avatar facup94 avatar joshfinnie avatar vvillait88 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

peopledatalabs-go's Issues

Client can't be injected because of private/internal structs

The pdl.New function returns a private struct, so its type can't be used to perform dependency injection:

type peopleDataLabs struct {
	pdlClient *pdl.pld // pld not exported by package peopledatalabs_go
}

func NewClient(apiKey string) MyInterface {
	return &peopleDataLabs{
		pdlClient: pdl.New(apiKey),
	}
}

The fields of the pdl.pld struct are not usable either because they're declared in internal:

// could not import github.com/peopledatalabs/peopledatalabs-go/internal/api (invalid use of internal package github.com/peopledatalabs/peopledatalabs-go/internal/api)
import pdlapi "github.com/peopledatalabs/peopledatalabs-go/internal/api"

type peopleDataLabs struct {
	pdlPersonClient pdlapi.Person // pld not exported by package peopledatalabs_go
}

func NewClient(apiKey string) MyInterface {
	return &peopleDataLabs{
		pdlClient: pdl.New(apiKey).Person,
	}
}

Can you make the pdl.pld struct public, or declare the internal/api structs public?
Thanks

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.