Code Monkey home page Code Monkey logo

comics's People

Contributors

dependabot[bot] avatar ferdnyc avatar lupusagax avatar pennomi avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

comics's Issues

When loading comments in the background, their height isn't set properly

This can be seen on swordscomic.com, e.g. by visiting this page:

https://swordscomic.com/comic/DCCLXVII/

then setting the "Info" tab active (if not already) and navigating to another comic, or even just refreshing the page. If the Comments tab is not the active tab on load (whether navigating from offsite or within the site), the (invisible) iframe detects its size as 0 and posts that value to the parent in its postMessage() call.

If the Comments tab is active when arriving at / navigating among the comics pages, then the frame will properly size on load.

This can be fixed by checking the element's .height property on activation of the tab, and forcing a refreshDiscourseComments() if there's no value set.

RSS Date formatting

In accordance with the RSS spec a feed is to use the RFC 822 format. Your feed does not and thus at least my RSS reader (NetNewsWire) completely fails to parse the date. (screenshot in the dd.mm.yyyy format)

Screen Shot 2022-06-20 at 11 20 45

The issue is in this line where you just include the date object instead of formatting it:

<pubDate>{{ page.posted_at }}</pubDate>

I don't have a lot of experience with Django but apparently this is how you format a template to this style. In regular python you'd format a datetime object like this.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.