pedrodesu / yew-feather Goto Github PK

I've forked yew-feather a few months ago under the assumption that you were not inactive. Thanks for coming back. Wondering, would you appreciate a PR? Let me summarize the changes I did:

1. Write a working build.rs script. This allows to cargo to compile the crate out of the box without preprocessing such as running npm run-script build. Makes easier to replace the dependency with a git dependency when overriding should yew continue to add breaking changes.
2. With the above, build fully in rust, including filling in the slug.rs file. This apparently speeds up compile time on my end compares to the js version.
3. Add a package.lock file to fix the version of feather-icons to depend on. No surprises and subtle differences in icon definitions.
4. Reuse the same Properties struct for all icons. This is mainly a codegen issue where expanding and checking all the derived impl Property etc has heavy costs which are sidestepping by reusing the properties struct. This alone cut compile times down from 10s to under 4s on my end. The rest seems to be the few hundred of icons definitions. It might be worth to add some (granular) features to enable/disable some icons to make this even faster. Keep in mind the timing is a crude wall-time measurement of this crate only I got from -Z timings and includes the download of feather-icons.
5. Upgrade the slug code to yew 0.19. I see you bumped the dependency version but didn't yet modify the code.

Let me know what you think, looking forward 🎉

I try to make use of yew-feather, but I get the build error below. Can you help?

use yew::prelude::*;
use yew::{function_component, html};
use yew_feather::camera::Camera;

#[function_component(Sidebar)]
pub fn sidebar() -> Html {
html! { }
}

A way to add onclick to icon would be really nice.
<XCircle size=20 onclick={remove_item}>

Is it possible to publish a new version of this crate ?

Thanks,
Marc-Antoine

Currently all props on icons are marked as &'static str, which means that it must be specified as a string literal.

Would it be possible to change the type of properties to AttrValue so that dynamic variables can be used?

https://docs.rs/yew/0.19.3/yew/virtual_dom/enum.AttrValue.html