peakytests / peaky Goto Github PK

In the new UI, when the left pane showing tests that can be run shows a long list of tests, then when you scroll the page down and run one, the result appears on the right-hand side out of view. You have to scroll back up to see it.

It would be useful to be able to see the test run time in the test results. For example, maybe a test start time as well as a duration.

originally requested by jonsequitur on Its.Log

Found while parallelizing tests:

<Message>System.InvalidOperationException : Collection was modified; enumeration operation may not execute.</Message>
          <StackTrace>   at System.ThrowHelper.ThrowInvalidOperationException_InvalidOperation_EnumFailedVersion()
   at System.Collections.Generic.List`1.Enumerator.MoveNextRare()
   at System.Linq.Enumerable.&lt;OfTypeIterator&gt;d__32`1.MoveNext()
   at System.Linq.Enumerable.Any[TSource](IEnumerable`1 source)
   at Peaky.ApplicationBuilderExtensions.UsePeaky(IApplicationBuilder app)
   at MLS.Orchestrator.Startup.Configure(IApplicationBuilder app, IApplicationLifetime lifetime, IServiceProvider serviceProvider, IAntiforgery antiforgery, ILoggerFactory loggerFactory) in /home/tyoverby/workspace/trydotnet/orchestrator/MLS.Orchestrator/Startup.cs:line 242
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.AspNetCore.Hosting.ConventionBasedStartup.Configure(IApplicationBuilder app)
   at Microsoft.Extensions.DependencyInjection.IServiceCollectionExtensions.InjectApiVersionRoutePolicy.&lt;&gt;c__DisplayClass2_0.&lt;Configure&gt;b__0(IApplicationBuilder app)
   at Microsoft.AspNetCore.Hosting.Internal.AutoRequestServicesStartupFilter.&lt;&gt;c__DisplayClass0_0.&lt;Configure&gt;b__0(IApplicationBuilder builder)
   at Microsoft.AspNetCore.Hosting.Internal.WebHost.BuildApplication()
   at Microsoft.AspNetCore.Hosting.WebHostBuilder.Build()
   at Microsoft.AspNetCore.TestHost.TestServer..ctor(IWebHostBuilder builder, IFeatureCollection featureCollection)
   at MLS.Orchestrator.Tests.OrchestratorService.CreateTestServer(Action`1 configureServices, Action`1[] agents) in /home/tyoverby/workspace/trydotnet/orchestrator/MLS.Orchestrator.Tests/OrchestratorService.cs:line 46
   at MLS.Orchestrator.Tests.OrchestratorService..ctor(Action`1 configureServices, Action`1[] agents) in /home/tyoverby/workspace/trydotnet/orchestrator/MLS.Orchestrator.Tests/OrchestratorService.cs:line 35
   at MLS.Orchestrator.Tests.OrchestratorService..ctor(Action`1[] agents) in /home/tyoverby/workspace/trydotnet/orchestrator/MLS.Orchestrator.Tests/OrchestratorService.cs:line 29
   at MLS.Orchestrator.Tests.WorkspaceController_Specs.&lt;Compile_with_a_null_snippet_returns_bad_request&gt;d__0.MoveNext() in /home/tyoverby/workspace/trydotnet/orchestrator/MLS.Orchestrator.Tests/Workspace_Controller_Specs.cs:line 14
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()</StackTrace>
        </ErrorInfo>
      </Output>

Workaround: don't use this method in unit tests.

For example:

TestClass A depends on Dependency1 and has a registration for it in the test targets.
TestClass B does not depend on Dependency1 and has no registration for it in the test targets.
When resolving all test classes during test discovery where any class valid for that URL, e.g.

/tests/environment/TestClassB --> 500
/tests/environment/TestClassA --> 200
/tests/environment --> 500

originally filed by jonsequitur

In this case, the tests should be routed but indicate failure.

this is the last functionality that needs to be implemented that was available in the old UI.

The Api returns all discovered tests in a field called .Tests from the MonitoringTestController. If you have a camel case contract resolver, then .tests is the property from that controller.

Need to either make the knockout check both cases, or configure the monitoring test controller to use the default contract resolver.

Currently, both the "expand" (+) button and the "collapse" (-) button are visible at the same time, regardless of the toggled state of a given test result.

This might be a little easier to use than having to click the little [+] [-] buttons.

Exception in thrown on MapTestRoutes call.
This very likely is the case for more than just strings.

[ArgumentException: Expression of type 'System.Object' cannot be used for parameter of type 'System.String' of method 'System.Threading.Tasks.Task1[System.Object] CreateCustomClock(System.String)']
System.Linq.Expressions.Expression.ValidateOneArgument(MethodBase method, ExpressionType nodeKind, Expression arg, ParameterInfo pi) +4401680
System.Linq.Expressions.Expression.ValidateArgumentTypes(MethodBase method, ExpressionType nodeKind, ReadOnlyCollection1& arguments) +138 System.Linq.Expressions.Expression.Call(Expression instance, MethodInfo method, IEnumerable1 arguments) +70
Its.Log.Monitoring.TestDefinition1.BuildTestMethodExpression(MethodInfo methodInfo, IEnumerable1 parameters) +213
Its.Log.Monitoring.TestDefinition`1..ctor(MethodInfo methodInfo) +300

[TargetInvocationException: Exception has been thrown by the target of an invocation.]
System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor) +0
System.Reflection.RuntimeConstructorInfo.Invoke(BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture) +243
System.RuntimeType.CreateInstanceImpl(BindingFlags bindingAttr, Binder binder, Object[] args, CultureInfo culture, Object[] activationAttributes, StackCrawlMark& stackMark) +1065
System.Activator.CreateInstance(Type type, BindingFlags bindingAttr, Binder binder, Object[] args, CultureInfo culture, Object[] activationAttributes) +124
System.Activator.CreateInstance(Type type, BindingFlags bindingAttr, Binder binder, Object[] args, CultureInfo culture) +20
Its.Log.Monitoring.TestDefinition.Create(MethodInfo methodInfo) +138
System.Linq.WhereSelectArrayIterator2.MoveNext() +58 System.Linq.<SelectManyIterator>d__162.MoveNext() +227
Its.Log.Monitoring.TestDiscovery.GetTestDefinitions(IEnumerable1 monitoringTests) +341 Its.Log.Monitoring.HttpConfigurationExtensions.MapTestRoutes(HttpConfiguration configuration, Action1 configureTargets, String baseUri, IEnumerable1 testTypes, HttpMessageHandler handler, String testUiScriptUrl, IEnumerable1 testUiLibraryUrls) +754
Microsoft.Datamarket.Monitoring.Web.Startup.Configuration(IAppBuilder app) in C:\Git\monitoring\Monitor.Web\Startup.cs:469

[TargetInvocationException: Exception has been thrown by the target of an invocation.]
System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor) +0
System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(Object obj, Object[] parameters, Object[] arguments) +92
System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture) +101
System.Reflection.MethodBase.Invoke(Object obj, Object[] parameters) +21
Owin.Loader.<>c__DisplayClass12.b__b(IAppBuilder builder) +77
Owin.Loader.<>c__DisplayClass1.b__0(IAppBuilder builder) +139
Microsoft.Owin.Host.SystemWeb.<>c__DisplayClass2.b__0(IAppBuilder builder) +69
Microsoft.Owin.Host.SystemWeb.OwinAppContext.Initialize(Action1 startup) +546 Microsoft.Owin.Host.SystemWeb.OwinBuilder.Build(Action1 startup) +58
Microsoft.Owin.Host.SystemWeb.OwinHttpModule.InitializeBlueprint() +95
System.Threading.LazyInitializer.EnsureInitializedCore(T& target, Boolean& initialized, Object& syncLock, Func1 valueFactory) +115 System.Threading.LazyInitializer.EnsureInitialized(T& target, Boolean& initialized, Object& syncLock, Func1 valueFactory) +72
Microsoft.Owin.Host.SystemWeb.OwinHttpModule.Init(HttpApplication context) +96
System.Web.HttpApplication.RegisterEventSubscriptionsWithIIS(IntPtr appContext, HttpContext context, MethodInfo[] handlers) +534
System.Web.HttpApplication.InitSpecial(HttpApplicationState state, MethodInfo[] handlers, IntPtr appContext, HttpContext context) +172
System.Web.HttpApplicationFactory.GetSpecialApplicationInstance(IntPtr appContext, HttpContext context) +339
System.Web.Hosting.PipelineRuntime.InitializeApplication(IntPtr appContext) +296

[HttpException (0x80004005): Exception has been thrown by the target of an invocation.]
System.Web.HttpRuntime.FirstRequestInit(HttpContext context) +9946132
System.Web.HttpRuntime.EnsureFirstRequestInit(HttpContext context) +90
System.Web.HttpRuntime.ProcessRequestNotificationPrivate(IIS7WorkerRequest wr, HttpContext context) +261`

It would be nice to render string properties that are URLs (matching /^https?/) as links automatically (with target="_blank")

originally requested by nathanboktae in Its.Log