musictouch's People
musictouch's Issues
Add a loading animation while reading data from Media Library
Introduce KVO
For:
- progress bar;
- album title;
- artist name;
- song title
update
Adapt to dark-mode
Capture start/pause event from headphones button
When the music is paused/started using the headphones button the app is not aware of the event
Reproduce:
- The music is playing
- Tap the screen to pause it
- Press the headphones button to start playing it again
The app is not aware that the music is again playing and the UI is not updated.
Refactor ViewControllers to have a Controller class
Remove or move Airplay icon
In the playing view, the small tv airplay icon is shown by default in the left upper corner.
Could be better if it is not shown or it can be shown in the left bottom corner of the view.
Remove VHUD dependency
VHUD is used to show volume percentage while volume is being increased or decreased.
I prefer to have a blurred image covering the view from bottom to top in the same percentage as the volume is.
Use persistentId to Media Library searches instead of name, titles, etc.
Some code cleaning
To remove unuseful commented code, add optional checks, ...
To use dependency injection to prepare to have unit tests
Media library should be injected
Volume transparent box bottom is not linked to the safe area bottom in landscape mode
Improve loading data performance
Create a mock data-store class
In order to perform UI automated tests, as the Xcode iPhone simulators don't have a Music Library, the data-store class must simulate a real access to the Music Library and return fake MPMediaItems in all its methods.
Remove Cocoapods dependencies and use Swift packages instead
Add an audio equalizer animation over the album artwork while playing
Remove data cache. Read data directly from media library
It should speed the app when loading.
Add UI tests
Add Unitary Tests
Use Swift Combine to decouple layers
Albums view does not enable "play all" and "shuffle" icons
Blur effect on landscape mode doesn't cover all the background image
Fix problems detected by Codebeat
Average color crashes
Randomly, average color calculation in UIImage extension crashes.
Improve tableview cells
Now, tableview cells show a rounded image and a label text.
To improve its layout and the information it shows:
- For playlists: image + playlist name + number of songs + total play time
- For artists: image + artist name + number of albums + total play time
- For albums: image + album title + year + number of songs + total play time
- For songs: image + song title + play time + order within the album (if browsing from albums view)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.