The openmp-lab-exercises from pdc-support

openmp-lab-exercises's People

Contributors

Stargazers

Watchers

openmp-lab-exercises's Issues

Wrongly allocated dimensions for ffy and nFx in c/shwater2d.c?

The dimensions of ffx,nFx and ffy,nFy should be m and n respectively.
Also there is no need to setup nF*[0] in the loop.

The proposed fix is below:

*** shwater2d.c	2019-08-20 19:55:55.914369395 +0200
--- shwater2d-fixed.c	2019-08-20 20:10:27.036256115 +0200
*************** int main(int argc, char **argv) {
*** 187,197 ****
    nFy = (double **) malloc(cell_size * sizeof(double *));
  
    ffx[0] = (double *) malloc(cell_size * m * sizeof(double));
!   ffy[0] = (double *) malloc(cell_size * m * sizeof(double));
!   nFx[0] = (double *) malloc(cell_size * n * sizeof(double));
    nFy[0] = (double *) malloc(cell_size * n * sizeof(double));
  
!   for (i = 0; i < cell_size; i++) {
      ffx[i] =  ffx[0] + i * m;
      nFx[i] =  nFx[0] + i * m;
      ffy[i] =  ffy[0] + i * n;
--- 187,197 ----
    nFy = (double **) malloc(cell_size * sizeof(double *));
  
    ffx[0] = (double *) malloc(cell_size * m * sizeof(double));
!   ffy[0] = (double *) malloc(cell_size * n * sizeof(double));
!   nFx[0] = (double *) malloc(cell_size * m * sizeof(double));
    nFy[0] = (double *) malloc(cell_size * n * sizeof(double));
  
!   for (i = 1; i < cell_size; i++) {
      ffx[i] =  ffx[0] + i * m;
      nFx[i] =  nFx[0] + i * m;
      ffy[i] =  ffy[0] + i * n;

copy-pasting from pdf instructions results in incorrect hyphens

The instruction files in pdf format are dangerous, copy-pasting commands from them leads to errors when running jobs or compiling. Consider moving over to markdown entirely!