pcai / safe_query Goto Github PK

safe query raises when eager loading on a resultset using #includes that only has a single related record. this is because activerecord doesnt generate an IN clause, but rather an equals clause. safe query doesnt recognize that the generated query is bounded because the query is matching on a primary key.

the detection code should ideally figure out if the clause is equality matching on a unique column or pk so it doesnt throw on those queries

The tests at https://github.com/pcai/safe_query/blob/main/spec/activerecord/safe_query_spec.rb are missing a case mentioned in the docs

Namely, a potentially unsafe query that would normally raise an exception can be avoided by converting the relation to an array first.

This case should be explicitly tested in the specs