pbhogan / signals Goto Github PK

View Code? Open in Web Editor NEW

499.0 499.0 50.0 217 KB

A lightweight signals and slots implementation.

C++ 100.00%

signals's People

Contributors

Stargazers

Watchers

Forkers

bslima scooterman spectermk decavoid jinserk peterclemenko stinkfist0 zvelo swq0553 liukun michael-chung cnsoft millerwm daodaoliang georgvolkert gerasim13 claudiouzelac chrisidefix jslhs yanlinaung daemonna sailfish009 neuroradiology asmello jordonwu from-explore kumorikuma hyperiongroup bbants kzantow-audio zhujie358 baddddy retval zuowanbushiwo erdinckaya how0723 alexander8402 yuexiahu wutianjun5858 alex-v-dev ssdcoder kileven cmaughan gicho kerwinzxc maksym-pasichnyk ssreepathy gerhobbelt rubykc linecode

signals's Issues

CL compilation error in Delegate.h

Hi,

first of all many thanks for your very cool signal/slot implementation.
Unfortunately I'm having the following compilation error using the cl compiler (VS):

f:\dev\test_client\externals\signal_slot\Delegate.h(513) : error C2039: 'funcaddress' : is not a member of 'Gallant::detail::SimplifyMemFunc<16>::Convert::<unnamed-type-u>::<unnamed-type-s>'
        f:\dev\test_client\externals\signal_slot\Delegate.h(503) : see declaration of 'Gallant::detail::SimplifyMemFunc<16>::Convert::<unnamed-type-u>::<unnamed-type-s>'
        f:\dev\test_client\externals\signal_slot\Delegate.h(702) : see reference to function template instantiation 'Gallant::detail::GenericClass *Gallant::detail::SimplifyMemFunc<16>::Convert<X,XMemFunc,Gallant::DelegateMemento::GenericMemFuncType>(X *,XFuncType,GenericMemFuncType &)' being compiled
        with
        [
            X=StandaloneConfigDialog
,            XMemFunc=void (__thiscall StandaloneConfigDialog::* )(void)
,            XFuncType=void (__thiscall StandaloneConfigDialog::* )(void)
,            GenericMemFuncType=Gallant::DelegateMemento::GenericMemFuncType
        ]

I've already fixed it locally for my project, so I can send you a patch for this if required.
Basically in my project I just adapted the following line (513) in Delegate.h

bound_func = u.s.m_funcaddress;

This one was causing the error, since the "funcaddress" is not a member of struct 's'.

Thanks.

Is this thread safe?

License in Delegate.h looks wrong

Your README and the article itself both specify the Delegate.h code as public domain, but the file itself claims it is under the Code Project Open License (CPOL) which is anything but public domain...

Would it be possible to update the license statement (if need be, clarifying with the authors that CPOL is not the licensing conditions for Delegate.h)? If the CPOL is in the mix, code concerned about GPL compatibility is basically dead in the water as far as using Signals... :-(

Gallant signals header guards conflicts on android NDK

The file Signals.h defines it's header guard with:

 #ifndef _SIGNAL_H_
 #define _SIGNAL_H_

This name clashes on android NDK, making the header to not be included and thus making the lib unusable on it.

I could fix it myself and send a patch, if needed :)

Thanks,

pbhogan / signals Goto Github PK

signals's People

Contributors

Stargazers

Watchers

Forkers

signals's Issues

CL compilation error in Delegate.h

Is this thread safe?

License in Delegate.h looks wrong

Gallant signals header guards conflicts on android NDK

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent