[Bug] Currency change not reliable about react-paypal-js HOT 6 CLOSED

Hello @gregjopa sorry for not providing the example right away, I was in the middle of the investigation, and just thought about it.

What we actually could do is say to the users to:

If you run the `resetOptions` inside a `useEffect` call, you must add an if statement inside to check if the previous script was already resolved, because this can cause a race-condition and make the call not very reliable.

from react-paypal-js.

Hi @pedroapfilho can you provide a full example of the problem? Perhaps you can update the Storybook Currency example to demostrate the issue: https://paypal.github.io/react-paypal-js/iframe.html?id=example-usepaypalscriptreducer--currency&viewMode=story.

from react-paypal-js.

The other thing that comes to mind is to add a check to make sure the script is finished loading before dispatching the resetOptions action. I'm wondering if the problem is the script is still loading when you try to dispatch this event so it doesn't get picked up properly because of this code: https://github.com/paypal/react-paypal-js/blob/main/src/ScriptContext.tsx#L101

If so, adding this check should resolve the issue.

if (isResolved && selectedCurrency !== defaultCurrency) {
    paypalDispatch({
    type: "resetOptions",
    value: {
        ...options,
        currency: selectedCurrency,
    },
    });
}

from react-paypal-js.

I'll create an example on the storybook today, stay tuned for the PR.

from react-paypal-js.

Do you think this feature request would help your use case with setting currency later on after defining the Script Provider? #89.

from react-paypal-js.

Yes and no.

It could help if we wanted to lazy load the component until we have the currency figured out, or we can basically trigger it after isResolved, just like you added on your comment.

from react-paypal-js.