paymenthighway / paymenthighway-php-lib Goto Github PK

We're using library version 1.6.0. Our static code analysis tool picked up the following error

ERROR: InvalidArgument - PaymentHighway.php:144:75 - 
Argument 6 of Solinor\PaymentHighway\Model\Request\Transaction::__construct 
expects Solinor\PaymentHighway\Model\Request\Splitting|null,
null|Solinor\PaymentHighway\Model\Splitting provided
$transaction = new Transaction($token, $amount, $currency, true, null, $splitting);

Your Transaction class is namespaced with Solinor\PaymentHighway\Model\Request and the constructor expects to receive Model\Request\Splitting, but there's no Splitting in Request. It's in Model, i.e Model\Splitting.

Transaction model has variable defined named orderId

public $orderId = null;

In constructor however $orderId is assigned to class variable order

public function __construct( $request, $amount, $currency, $blocking = true, $orderId = null )
...
$this->order = $orderId;

I'm assuming it should be orderId instead of order in constructor?

I got an error when i add this "solinor/paymenthighwayio" : "1.6.0" and update composer

"require" : 
{
    "solinor/paymenthighwayio" : "1.6.0"
}

Hi,

This package is using ramsey/uuid version 2.8, while Laravel 5.4 requires version ^3.0 and thus it cannot be installed by Composer. Could you update the dependencies requirement please?