paviliondev / discourse-quick-messages Goto Github PK

We should probably completely strip any leading quotes from the dropdown box, or at the very least, strip the [quote="user; post:1; topic:1"] from the portion displayed in the menu.

https://meta.discourse.org/t/quick-messages-plugin/39188/306?u=ryanerwin

Feature Request:
Make the avatar in the chat and the username in the top bar of the chat link to the user’s profile popup/modal like when you click on a username/avatar anywhere else in Discourse.

Thanks!

Hi,

I just updated my discourse to v2.4.5 and now discourse does not work anymore (webpages appear blank) unless I disable this plugin. I get "Error: Could not find module I18n imported from discourse/plugins/discourse-quick-messages/discourse/widgets/message-list" in the browser console.

Something similar is super important for Quick Messages considering that discourse by default has this feature for normal PMs.

Seems I am getting rebuild errors resulting from message-list.js.es6#L36. Disabling the plugin from the yaml yields a positive rebuild.

Bundling assets
rake aborted!
MiniRacer::RuntimeError: SyntaxError: unknown: Unexpected token (36:92)
JavaScript 34 |           if (m.message_excerpt) {
JavaScript 35 |             let excerpt = new RawHtml({
JavaScript > 36 |               html: `<div class='message-excerpt'>${emojiUnescape(m.message_excerpt)}</div>`;
JavaScript |                                                                                             ^
JavaScript 37 |             })
JavaScript 38 |             m.set('excerpt', excerpt);
JavaScript 39 |           }

Not showing up when accessed via the visit this user's preference page link on Admin > Users

On mobile, QM's composer / reader interface doesn't have as obvious a benefit compared to desktop mode, especially since you can't press CTRL+ENTER on mobile to enter a newline... Each newline results in a sent message with now way to insert a newline.

When we implement the "Menu mode only" feature, maybe we allow the choice of Desktop or Mobile...

Curious to hear what @angusmcleod thinks about this idea?

When typing a username but haven’t waited for the “To” box to show the actual username object…

vs

https://meta.discourse.org/t/quick-messages-plugin/39188/347?u=angus

The log is this one :

Hi'

We're seeing some problems with our branding-colors.

Are you able to fix this?

The user interface setting is not showing up when the user selection setting is enabled. I think it's an incorrect variable name in the client. See if you can find it.

https://meta.discourse.org/t/quick-messages-plugin/39188/286?u=ryanerwin

https://meta.discourse.org/t/quick-messages-plugin/39188/339?u=ryanerwin

I’ve noticed something today: when user receives a group message, Quick Message button in header shows new message indicator, but it does not show on the list:

Width of drop down ellipses... It’s almost as if it was sized intending for avatars to be displayed rather than usernames.

Currently...

Should be...

It’s just a matter of changing the width of that pop-up from 80px to 80%.

Fix at:

https://github.com/angusmcleod/discourse-quick-messages/blob/3dc2fbcc676a58fae3aa1d53e8f7bee155afc408/assets/stylesheets/common/quick_composer.scss#L145

When composing a very short reply, you can get an error:

When you're using an instant messenger UI, I don't think that the typical Discourse minimum length type notification is relevant.

https://meta.discourse.org/t/quick-messages-plugin/39188/304?u=ryanerwin

I got this error in the launcher rebuild step cd /var/www/discourse && sudo -E -u discourse bundle exec rake multisite:migrate while upgrading Discourse from 2.3.1 to 2.3.6:

LoadError: Unable to autoload constant PostValidator, expected /var/www/discourse/lib/validators/post_validator.rb to define it
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:511:in `load_missing_constant'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:195:in `const_missing'
/var/www/discourse/plugins/discourse-quick-messages/plugin.rb:45:in `block in activate!'
/var/www/discourse/lib/plugin/instance.rb:331:in `block in notify_after_initialize'
/var/www/discourse/lib/plugin/instance.rb:329:in `each'
/var/www/discourse/lib/plugin/instance.rb:329:in `notify_after_initialize'
/var/www/discourse/config/application.rb:292:in `each'
/var/www/discourse/config/application.rb:292:in `block in <class:Application>'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-5.2.3/lib/active_support/lazy_load_hooks.rb:69:in `block in execute_hook'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-5.2.3/lib/active_support/lazy_load_hooks.rb:62:in `with_execution_control'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-5.2.3/lib/active_support/lazy_load_hooks.rb:67:in `execute_hook'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-5.2.3/lib/active_support/lazy_load_hooks.rb:52:in `block in run_load_hooks'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-5.2.3/lib/active_support/lazy_load_hooks.rb:51:in `each'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-5.2.3/lib/active_support/lazy_load_hooks.rb:51:in `run_load_hooks'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/railties-5.2.3/lib/rails/application/finisher.rb:75:in `block in <module:Finisher>'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/railties-5.2.3/lib/rails/initializable.rb:32:in `instance_exec'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/railties-5.2.3/lib/rails/initializable.rb:32:in `run'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/railties-5.2.3/lib/rails/initializable.rb:61:in `block in run_initializers'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/railties-5.2.3/lib/rails/initializable.rb:60:in `run_initializers'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/railties-5.2.3/lib/rails/application.rb:361:in `initialize!'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/railties-5.2.3/lib/rails/railtie.rb:190:in `public_send'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/railties-5.2.3/lib/rails/railtie.rb:190:in `method_missing'
/var/www/discourse/config/environment.rb:7:in `<top (required)>'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:291:in `require'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:291:in `block in require'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:257:in `load_dependency'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:291:in `require'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/railties-5.2.3/lib/rails/application.rb:337:in `require_environment!'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/railties-5.2.3/lib/rails/application.rb:520:in `block in run_tasks_blocks'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rake-12.3.2/exe/rake:27:in `<top (required)>'
/usr/local/bin/bundle:23:in `load'
/usr/local/bin/bundle:23:in `<main>'
Tasks: TOP => multisite:migrate => environment
(See full trace by running task with --trace)

After disabling discourse-quick-message the rebuild process went through without problems.

https://meta.discourse.org/t/quick-messages-plugin/39188/343?u=angus

Today the message window stopped updating messages after I updated discourse, now I have to manually refresh the page to see new messages. There’s a bunch of errors in the console, here’s one

undefined has no properties errorLoading@https://community.naturephotographers.network/assets/application-67619619324877ff58c169ad978704406497af215c1b61758d8e37993b13f30d.js:11:8449 errorLoading@https://community.naturephotographers.network/assets/plugin-third-party-c04de63147a5ffb2056d55a1f598879c26a12874fcfadff77c2853c70981f498.js:1:1701 n@https://community.naturephotographers.network/assets/ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:16:13676 refresh/<@https://community.naturephotographers.network/assets/application-67619619324877ff58c169ad978704406497af215c1b61758d8e37993b13f30d.js:10:30341 A@https://community.naturephotographers.network/assets/ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:19:773 S@https://community.naturephotographers.network/assets/ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:19:887 C@https://community.naturephotographers.network/assets/ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:19:676 _@https://community.naturephotographers.network/assets/ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:19:156 invokeWithOnError@https://community.naturephotographers.network/assets/ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:7:19374 flush@https://community.naturephotographers.network/assets/ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:7:19832 flush@https://community.naturephotographers.network/assets/ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:7:20592 end@https://community.naturephotographers.network/assets/ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:7:20937 run@https://community.naturephotographers.network/assets/ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:7:22006 u@https://community.naturephotographers.network/assets/ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:13:2804 e/i.error@https://community.naturephotographers.network/assets/application-67619619324877ff58c169ad978704406497af215c1b61758d8e37993b13f30d.js:7:12737 c@https://community.naturephotographers.network/assets/ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:2:7300 fireWith@https://community.naturephotographers.network/assets/ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:2:8054 r@https://community.naturephotographers.network/assets/ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:3:11484 n/<@https://community.naturephotographers.network/assets/ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:3:16306 _ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:29446:6

u _ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:29446:6 o _ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:29425:6 i _ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:42938:6 trigger _ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:57309:10 _onError/< _ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:58212:10 invokeWithOnError _ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:12554:8 flush _ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:12613:8 flush _ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:12737:8 end _ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:12807:6 run _ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:12921:10 u _ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:33988:11 e/i.error _application-67619619324877ff58c169ad978704406497af215c1b61758d8e37993b13f30d.js:9182:8 c _ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:3272:10 fireWith _ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:3402:6 r _ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:9311:4 n/< _ember_jquery-27e777857b8c0730dacfe09cb11711365d21a5db4f9ee0b85d494e4259cf6cda.js:9544:9

Currently you have to click the top right Navigate to message topic button,
then scroll down to the bottom to be able to "Like" the reply

The Skype style reply liking may work better

Can you add Russian to this plugin?

Hello, i did pullrequest what have been merged with polish language update, but after update plugin on my forum, theres no translation for placeholder

https://github.com/paviliondev/discourse-quick-messages/pull/56/files#diff-d68fcc4f300b285398ddaac304052b52R4

Currently I seem to be limited to two on Desktop and 1 on mobile

Opening the default "User Menu" is instant, but there is significant latency opening the Quick Messages Menu.... Should find a way to pre-load this like the User Menu.

https://meta.discourse.org/t/quick-messages-plugin/39188/305?u=ryanerwin

One thing I would really like to see is the ability to only use the toolbar part of the quick messages plugin, I really like the way it makes the private message functionality more obvious with the big button in the top toolbar!

Unfortunately the facebook style message popups are really tricky to make work correctly if you have custom themes or theme components like the header search or material theme and so on, and if you write a typical Discourse post with lots of paragraphs it becomes kinda unreadable in the quick message popup.

Add the URL and Settings links in the Discourse Admin page like:

# url: https://github.com/angusmcleod/discourse-quick-messages
enabled_site_setting :quick_messages

When sending a PM via the regular UI or via Quick Messages, you get a push message notification…

If you click it, you’ll be directed to the traditional “PM” box, rather than the Quick Messages UI

After upgrading Discourse to 2.8.0beta4, the plugin no longer displays message text. For your own messages, there are only empty blue bubbles. The DOM inspector shows that the div does not contain any text.

I'd be happy to try to fix this but I need some guidance ;) Thanks.

BUG: “Maintain QM position and state across browser refreshes”

You can browse to different pages without QM disappearing, but as soon as you hit “Refresh” you’re open QM windows are lost… Would like these windows to be preserved across refreshes and ideally even across site visits (but should be specific to the browser, not the to user since different devices with different resolutions would suggest different layouts)

Users are complaining that they can't middle-click to open messages from the quick-message list on the notification bar. Looking at it, it seems they are only div's, they should be anchor's with javascript preventing default action so middle-clicks will open the full message page link.

Ability to use quick messages is determined by badge

If you type some content, then press the "X" to close, you can get error:

This can make it impossible to close quick messages... because the error is in the back ground, but sometimes the error still has focus... (even though it's visually behind the quick messages window and can't be seen)

Solution is probably to check if there is CONTENT in the reply box when clicking "Close" and if there is content, then trigger the Yes, abandon / No, keep dialog in front of the show quick messages window...

Since Discourse now supports multiple saved drafts, might be even better to just silently save the replies as new drafts and not bother prompting... but if we did that, then how to recover your draft?

https://meta.discourse.org/t/quick-messages-plugin/39188/304?u=ryanerwin

Hi there, i am running v1.7.0.beta6 +17.
It turned out that your plugin shows the green dot on new messages
but the box always shows No messages yet. - which is a bit sad :/

Hi'

We're facing problems after quick-messages is updated with docker_manger. It's the only plugin causing problems after restart of the webserver.

Are you able to fix it? :-)

The "error" is fixed again, after another restart of the webserver (which happens after the next plugin is updated 😄 We're normally updating the plugins one by one, by pressing the update-button in the docker_manager interface)

https://meta.discourse.org/t/quick-messages-plugin/39188/314?u=ryanerwin

@angus I discovered a bug with this plugin on mobile. When opening a quick message chat, the composer and keyboard pops up fine, but when you minimize the chat and then open it again the keyboard pops up correctly but the composer does not appear. Typing is still possible but the user cannot see what he is typing unless he hides the keyboard everytime which hinders UX. I encountered this on a Samsung Galaxy S8+ on Chrome (web app of my site).

https://meta.discourse.org/t/quick-messages-plugin/39188/286?u=ryanerwin

Before refresh (counter updated form 1 to 2)

However, after refresh.... new messages show up

I have seen situations where the new messages arrived yet the box doesn’t scroll down… looking like this. I don’t have REPRO steps yet though, but I’ve seen it multiple times.