CDN support for custom card icons about patternfly-quickstarts HOT 4 CLOSED

https://user-images.githubusercontent.com/981838/135095293-902e820c-45ad-43c5-8dca-a00fd849263b.png

from patternfly-quickstarts.

Hi @tiffanynolan

1. you can pass an icon directly in the yaml file using the base64 approach, this would not require any further setup/dependencies on the consumer side. If you want to pass other formats, it is possible.
   For example, you can define the quick start content in javascript, and pass the icon as a ReactNode, like here:
   https://stackblitz.com/edit/react-ts-wcc244?file=quick-starts%2Fquickstart-three.tsx
   There are multiple options, you could even have a lookup map in the code that would insert the right icon at runtime

2. Curious how CDN loaded images would improve page load?

from patternfly-quickstarts.

Repeated images of the same dataurl will reoccur in bundle.
Problem can be solved by:

• cdn /url
• bundler/code splitting
• ignored (accept up to 100kb penality in pessimistic scenario)

We use yaml format

from patternfly-quickstarts.

I think these are all either handled already or need to be done on consumer side:

• you can pass href to icon in yaml so that already works (example: icon: https://discuss-assets.s3.amazonaws.com/original/3X/1/9/19823cc1f1f887d70755e0b500dd8ce2c51ba7f9.svg
• can setup for example webpack to map quickstarts to icons, and inject those icons at runtime

I'll close this for now, but feel free to let me know if I am still missing something

thanks!

from patternfly-quickstarts.