patrikf / glip Goto Github PK

Hey, i found that you use usort function for sorting nodes within Git Tree object, but as said in PHP Manual, usort will loose array keys, and You will no longer be able to get nodes by they're key. You can use uasort function instead, to keep array keys.

Best Regards,
canni

Hello all,

Can this be used to make a "git pull" on a server without having git cli ?

How can we do that? I didn't understand with the doc

Hi folks!

It's been a long while since I last touched glip, I no longer have use for the code myself and hence no interest in developing it any further. However, I see continued activity in my Github feed; there's a few open pull requests, lots of people have forked and made a few changes themselves.

I would like to offer official maintainership to anyone who feels up to the task. It would be useful to consolidate the additions that people made, possibly add a unit-testing suite, and have a vision for the API to evolve. Anyone interested?

Please respond here or by email to [email protected].

Thanks,
Patrik

glip doesn't distinguish between a normal directory and a git submodule. If you make a call to GitTree::listRecursive() on a repo that contains a git submodule then glip will error out because the git sumodule directory is not actually part of the containing repo. The GitTree::listRecursive() call errors out like:

Uncaught exception 'Exception' with message 'object not found: <sha of git submodule>'

glip attempts to traverse the git sumodule directory, but it's not part of the current repo so it cannot find the object (the object does exist, but it's in the git submodule's repo).

Here's a nice tutorial on submodule usage:
http://book.git-scm.com/5_submodules.html

If you follow that example and try to listRecursive the master repo tree you will get this error.

glip needs to recognise that a directory is actually a git submodule and not part of the repo specified when the initial Git instance was created. glip should then not attempt to traverse that directory. The fact that a directory is actually a Git submodule could be reflected in the return value of GitTree::listRecursive() so that a calling function doesn't then blindly try to make a getObject() call directly on a git submodule.

I've forked the code and will submit a fix I've come up with soon. glip has been great fun to play around with!