pathbreak / opencv_contrib Goto Github PK

1. Currently ml and flann are mandatory dependencies, but they are required only by an example.
   Add them as dependencies only if building examples.

2. Currently text (OCR) module is an optional dependency. However, it's required by an example and that example will fail to build if this module is not selected in the build. So it should be a dependency only when building examples, and a mandatory one when doing so.

This module does not really depend on anything but its CMakelists contains:

• dnn
• imgproc
• highgui
• imgcodecs

and module header too includes them.

All these dependencies are required only by its examples. Make them conditional in CMakelists and remove their #includes.

Update link to EPFL multi-view stereo dataset from http://cvlabwww.epfl.ch/~strecha/multiview/denseMVS.html to https://icwww.epfl.ch/multiview/denseMVS.html

bioinspired module build fails if examples are selected for build but imgproc is not selected.

Add missing required dependencies to CMakeLists:

• imgcodecs

Remove unused dependencies:

• highgui
• calib3d

Move other dependencies to samples only:

• features2d
• viz

Remove unnecessary #includes from header file.

Only samples use highgui. However, marking it as an optional dependency is not correct, because optional should be used only if module can build even if dependency is not included in the build. For dpm samples, highgui is actually a mandatory dep because it doesn't build if highgui is not included.

There's no need to make it a mandatory dependency either since highgui is included anyway as automatic dependency when building examples, and if highgui is not included in build, samples are not built.

Only bioinspired samples use highgui. However, marking it as an optional dependency is not correct, because optional should be used only if module can build even if dependency is not included in the build. For bioinspired samples, highgui is actually a mandatory dep because it doesn't build if highgui is not included.

There's no need to make it a mandatory dependency either since highgui is included anyway as automatic dependency when building examples, and if highgui is not included in build, samples are not built.

contrib/face adds objdetect and photo modules as mandatory dependencies though they are used only by samples.

Update link to PARSE human pose estimation dataset from http://www.ics.uci.edu/~dramanan/papers/parse/ (which is a dead link now) to https://www.cs.cmu.edu/~deva/papers/parse/index.html.