pasqualerossi / 42-school-exam-rank-04 Goto Github PK

You deleted implementation about pipe in this commit.
So the current program on master branch don't allow us to use pipe for example $>./microshell /bin/ls "|" /usr/bin/grep microshell ";" /bin/echo i love my microshell

You have to add a protection in the write_error to avoid a segfault when string or argv are NULL.

it is reported that using the __environ is not allowed in the test.
In general, it's recommended to use environ rather than __environ, because environ is standardized by POSIX and is more portable across different systems. The __environ variable is not standardized and might not be available on all systems.
I would advise to use:

extern char **environ;

which is not a global and it is posix compliant.

I just passed microshell with shorter code.
gist
This subject is no need to dupplicate 0 in fd for backup. it no use in this subject.

A lot of big mistakes in this code, it s odd that the moulinette allowed this to pass :

• STDIN and STDOUT are not restored at the end of a pipeline, args like ./microshell "/bin/echo" "a" "|" "/bin/cat" "-e" "|" "/bin/wc" "-l" ";" "/bin/cat" will not work correctly (the last cat should read on STDIN).

• Commands in a pipeline do not work simultaneously, args like ./microshell "/bin/yes" "|" "head" "-n" "20" will result in an infinite loop because the 'head' command will never start and cant sigpipe the first command. You must launch each command of the pipeline before waiting with waitpid.

It's disappointing to promote this kind of program even though the moulinette won't KO it.