Code Monkey home page Code Monkey logo

Comments (15)

tlapusan avatar tlapusan commented on May 13, 2024 1

Indeed, if I look again at above visualisation, it looks 'scattered'. I will adjust it to the vertical stack version. Let's see how it'll look ;)

from dtreeviz.

parrt avatar parrt commented on May 13, 2024

Looks pretty cool! I think our goal, though, is to show the path from root to predictor leaf in a big tree as tightly as possible. I wonder what it looks like as a vertical stack of just the decision nodes entered and then the leaf. That would be the smallest footprint, which I think is kind of the goal here. what do you think?

from dtreeviz.

tlapusan avatar tlapusan commented on May 13, 2024

It looks much cleaner now :)
Screenshot 2019-11-28 at 22 55 03

from dtreeviz.

parrt avatar parrt commented on May 13, 2024

heh, nice work! I like it. Does it work horizontally too? I think we have an option for that.

from dtreeviz.

tlapusan avatar tlapusan commented on May 13, 2024

cool. By horizontally.... do you mean a horizontal stack instead of vertical stack ?

from dtreeviz.

parrt avatar parrt commented on May 13, 2024

yep, left to right

from dtreeviz.

tlapusan avatar tlapusan commented on May 13, 2024

wouldn't be a problem if the prediction path is very deep ? I think we will end with a 'crowdy' plot.

from dtreeviz.

parrt avatar parrt commented on May 13, 2024

well, sometimes you want very tall and sometimes very wide. seems like original code can change orientation so this should inherit that; i assume you just cut/paste, right?

from dtreeviz.

tlapusan avatar tlapusan commented on May 13, 2024

I wanted to use as much functionality as possible from dtreeviz(), so I didn't cut/paste. I will take a look for horizontal view. There is little work left also for vertical view, I made a little 'hack' to create the visualisation with vertical view for decision nodes only :)

from dtreeviz.

parrt avatar parrt commented on May 13, 2024

We can skip horizontal if it gets messy in the code :)

from dtreeviz.

tlapusan avatar tlapusan commented on May 13, 2024

For horizontal view I didn't have to do any extra logic, it was already in dtreeviz() code ;)

Should I make a PR ?

Screenshot 2019-11-30 at 19 02 33

Screenshot 2019-11-30 at 19 03 22

from dtreeviz.

parrt avatar parrt commented on May 13, 2024

Looks great! Only question is, how do we activate this? Seems like it should be an arg to existing tree viz functions. Oh, I see you have show_just_path. Sounds good! Please do make a PR. Does it work for regression trees too?

from dtreeviz.

tlapusan avatar tlapusan commented on May 13, 2024

I didn't try it on regression trees. I will try it tomorrow.

from dtreeviz.

tlapusan avatar tlapusan commented on May 13, 2024

yey, it works also for regression trees. I will create a PR for this.

Screenshot 2019-12-01 at 16 59 27

from dtreeviz.

parrt avatar parrt commented on May 13, 2024

great job!

from dtreeviz.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.