Code Monkey home page Code Monkey logo

Comments (5)

tlapusan avatar tlapusan commented on May 24, 2024 1

Indeed @MohammedAlsayed, the error message should be more precise. If you can make a PR for this and display a more relevant error message it would help.

from dtreeviz.

tlapusan avatar tlapusan commented on May 24, 2024

Hi @MohammedAlsayed,

thanks for your feedback and appreciation for the library.
In the case we have to work with a binary classification problem, by default the classes should be converter to 0 and 1 integer values from the client side.

Not sure if we should add this conversion into the library.

Thanks,
Tudor.

from dtreeviz.

MohammedAlsayed avatar MohammedAlsayed commented on May 24, 2024

Hi @tlapusan,

Thanks for your reply.

I never faced this issue with other libraries like sklearn, or xgboost in binary classification even though my target is type float. I guess this library should be consistent with other libraries as well. It doesn't make sense that it works perfectly in other libraries then crashes here.

However, if there is no desire to add this feature, then the error message should be more precise than what it shows. Since, it took me time to know what is the issue.

from dtreeviz.

MohammedAlsayed avatar MohammedAlsayed commented on May 24, 2024

@tlapusan I think I need to be added as a collaborator to be able to pull a request. Shall I pull on master or dev branch?

from dtreeviz.

tlapusan avatar tlapusan commented on May 24, 2024

Can you describe a little more what do you mean by collaborator ? anyone should have permission to make the PR.
Yes, into dev branch. thanks.

from dtreeviz.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.