paroj / dsub2000 Goto Github PK

hi all, any interest in OpenSubsonic support? https://opensubsonic.netlify.app/

what I think would be the most nice is multi-artist support, where for example an album may have a list of associated artists, not just one

clients like airsonic-refix, symfonium and supersonic support this today

When I try to update the dsub2000 install between CI artifact builds it says there is a conflicting app already installed.

Maybe it needs to build using the same signature?

I connect to my navidrome server and most of the time I want to play a smart playlist generated on the server. This playlist highly depends on the "last played" field. So, scrobbling is an essential part of playing the songs. Each song that is not scrobbled will mess up the playlist and make me unhappy.

With the current behavior of the app, I can achieve full scrobbling in two ways:

1. Open playlist, refresh list, cache some songs, switch to offline mode, play songs and when I'm back online, use the sync dialog that pops up.
2. Open playlist, refresh list, stay online and connected the whole time and let the app scrobble after each song.

This has some problems:

• When the sync dialog after going back online somehow fails (because your device randomly disconnects, or the wifi does not offer an IPv6 address that lets me connect to my server) all scrobbles will be lost
• In offline mode (way 1) all songs that are not cached will be removed from the playlist. When I need to cache a few more songs later for my commute or whatever, it is a real hassle.
• Staying online just to send a few kB after every song causes battery drain on older devices, when the songs themselves are already cached
• Even when the device is connected, the connection might not be stable enough to successfully scrobble a song

I did some experiments on my fork but I was not happy with the complexity it would add. My idea was to use the OfflineMusicService as a fallback when the RESTMusicService failed to sync a scrobble (and star/unstar/rate/...) call. But the scrobble caching gave me a headache. They are stored in SharedPreferences either with an ID or the search criteria. It was not really made to do more than it does now.

In my opinion, the SharedPreferences are not suitable for what I want. I would suggest a simple database. But before I make my hands dirty, I would love to hear some other thoughts, wishes or maybe some ideas or solutions.

I was trying to build the app with cling's supported fork jupnp (see #10) when noticed that if you enable DLNA in Settings -> Casting it crashes even with cling, as it is now in edge. I bisected it down to 1de5177 being the one introduced the problem.

Do you plan to publish on Google Play, fDroid, Amazon App store?

I'd really like to see it show up in places where it is easier to install (for instance I have a device that can only use the Play store and side loading is prohibited). Thanks for picking this up!

An issue for reference purpose.

As far as I understand, it is regression of bac3852 (Follow material guidelines for side padding ).

I'm intending to submit PR promptly.

There should be an updated readme. The current one is not very useful, to put it nicely.

The new readme should include:

• Some introductory sentences with a short statement, that this is a fork of DSub
• A list of features
• A few nice screenshots
• once we have them: links to release page and app stores

Regarding publication in Fdroid: the application requires libraries from third party maven repo http://4thline.org/m2. Third party maven repositories is against Fdroid inclusion policy and the maintainers made it clear to get rid of 4thline repo (https://gitlab.com/fdroid/fdroiddata/-/merge_requests/3501). The required libs (cling and cling-support) aren't on maven central. There is a supported fork of cling - jupnp (https://github.com/jupnp/jupnp) but I failed to build the app with fresh versions of fork and old versions are not available on maven central. So, that's the problem to solve.

Originally posted by @norohind in #5 (comment)

Running instrumented tests fails on build stage with gradle saying

FAILURE: 
Build failed with an exception.
* What went wrong:
Execution failed for task ':app:connectedFlossDebugAndroidTest'.

In logcat it has following line in traceback

Caused by: java.lang.ClassNotFoundException: Didn't find class "kotlin.jvm.internal.Lambda"

Running instrumented tests requires kotlin standard library. After adding it to dependencies, tests gets run. Though not all of them get passed.

I'm intending to investigate why some tests are failing and submit a PR.

It appears that app tries to use some local proxy-like server (maybe ServerProxy module used exactly for this in the project) and it fails due to https only restriction (I guess regression of 4ecf202)

[04-14 14:36:02.531 6777:6813 E/ImageLoader]
Failed to download from url http://127.0.0.1:4533/share/img/<jwt token>?size=600
javax.net.ssl.SSLException: Only https connections are allowed!
	at github.daneren2005.dsub.service.RESTMusicService.getConnectionDirect(RESTMusicService.java:15)
	at github.daneren2005.dsub.service.RESTMusicService.getConnectionDirect(RESTMusicService.java:11)
	at github.daneren2005.dsub.service.RESTMusicService.getConnection(RESTMusicService.java:4)
	at github.daneren2005.dsub.service.RESTMusicService.getBitmapFromUrl(RESTMusicService.java:13)
	at github.daneren2005.dsub.service.RESTMusicService.getBitmap(RESTMusicService.java:14)
	at github.daneren2005.dsub.service.CachedMusicService.getBitmap(CachedMusicService.java:73)
	at github.daneren2005.dsub.util.ImageLoader$ViewUrlTask.doInBackground(ImageLoader.java:13)
	at github.daneren2005.dsub.util.BackgroundTask$Task.access$300(BackgroundTask.java:24)
	at github.daneren2005.dsub.util.BackgroundTask$TaskRunnable.run(BackgroundTask.java:30)
	at java.lang.Thread.run(Thread.java:923)

After couple seconds after it the app appeared to crash, it was playing in background with screen locked and for me, it just stopped playing, when I opened the app it loaded like it wasn't running in background. Beside these two exceptions (they were exactly the same and followed each other with 300 ms interval), I don't have any clue what happened to the app.

hi! thanks for the efforts here. wondering if we could get daneren2005#1151 from @brian-doherty in

and maybe see if could be applied to a situation where playback stops when locking the screen in the middle of a playlist (or at least when playing a track from the starred list) - if it's the same issue

thanks!