Code Monkey home page Code Monkey logo

Comments (5)

distler avatar distler commented on June 30, 2024

Thanks!!

Ruby 3.0 was on my to-do list.

Have you verified that all the tests pass?

bundle exec rake test

from instiki.

Shamaoke avatar Shamaoke commented on June 30, 2024

@distler

I've got two errors.

Failure: test_pages_by_revision(WebTest):
  <"EverBeenHated"> expected but was
  <"HomePage">.
test/unit/web_test.rb:12:in `test_pages_by_revision'
      9:
     10:   def test_pages_by_revision
     11:     add_sample_pages
  => 12:     assert_equal 'EverBeenHated', @web.select.by_revision.first.name
     13:   end
     14:
     15:   def test_pages_by_match

-------------------------------------------------------------------------------------------------------------------------------------------------------------
1235 tests, 2080 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
99.919% passed
-------------------------------------------------------------------------------------------------------------------------------------------------------------
Failure: test_dnsbl_filter_deny_action(WikiControllerTest):
  <403> expected but was
  <302>.
test/functional/wiki_controller_test.rb:809:in `test_dnsbl_filter_deny_action'
     806:     r = process 'save', 'web' => 'wiki1', 'id' => 'NewPage', 'content' => "Contents of a new page\r\n",
     807:       'author' => 'AuthorOfNewPage'
     808:
  => 809:     assert_equal 403, r.response_code
     810:     resp = [ %{<p>Access denied. Your IP address, 127.0.0.2, was found on one or more DNSBL blocking list(s).</p>\n},
     811:              %{<p>See <a href='http://www.spamcop.net/w3m?action=checkblock&amp;ip=127.0.0.2'>here</a> for more information.</p>\n},
     812:              %{<p>See <a href='http://www.spamhaus.org/query/bl?ip=127.0.0.2'>here</a> for more information.</p>\n}]

-------------------------------------------------------------------------------------------------------------------------------------------------------------
142 tests, 522 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
99.2958% passed
-------------------------------------------------------------------------------------------------------------------------------------------------------------

from instiki.

distler avatar distler commented on June 30, 2024

The second is a transient failure, which I wouldn't worry about. The first bears investigation....

from instiki.

distler avatar distler commented on June 30, 2024

With 8ef20e3, all tests seem to pass, both in Ruby 2.7 and Ruby 3.0. Thanks for doing the legwork on this.

from instiki.

Shamaoke avatar Shamaoke commented on June 30, 2024

Ok. Thanks for your work maintaining the project.

from instiki.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.