Code Monkey home page Code Monkey logo

Comments (5)

davidtanzer avatar davidtanzer commented on June 30, 2024

BUT: the fix I just described causes this to fail [[!include navigation]]

from instiki.

distler avatar distler commented on June 30, 2024

That's the same way interweb WikiLinks work. Don't you think they should be consistent?

from instiki.

davidtanzer avatar davidtanzer commented on June 30, 2024

I just tested it, interweb WikiLinks work both using the display name and the address.   I had always been using the address, and assumed on the basis of consistency that the new include statement would use that as well.

If I were designing it from scratch I would use address consistently everywhere, as it feels more permanent, doesn't contain spaces and capitalization; it's an identifier.   It would be good to be able to tweak the display name of a web without breaking links to its pages.

But that would break backward compatibility.    If it were me I would still deprecate it, and use just address in the new syntax.

But we're getting into subjective judgement calls.   Whatever you decide the intended behavior to be is fine, I'll follow that.

from instiki.

distler avatar distler commented on June 30, 2024

Actually, either the name or address (with the name preferred) are allowed for interweb WikiLinks.

So we should do the same here. Added in 60db4d4. Tweaked in f6f5482.

from instiki.

distler avatar distler commented on June 30, 2024

P.S.: You can perfectly well comment on a closed issue and even (if you were the one who opened it) reopen the issue. No need to open a new one, merely to add a comment.

from instiki.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.