Comments (4)
Worth mentioning: I have not tested any of the other form fields. I have not tested any of the other trigger types (and I know those will lead to different form fields).
Whoever investigates (and fixes) this bug, please take a look at all form fields to make sure they all behave consistently.
from paperless-ngx.
To a certain extent, this is user error. It seems clear enough that no sources will match nothing. We can probably add some validation to prevent empty sources though
from paperless-ngx.
In my humble opinion, it's not "clear enough".
Following the logic of "no sources will match nothing", we would expect that no filter path will match nothing as well. It's inconsistent among the form fields.
I believe the best option is to make "no sources" simply disable the source-checking, just like empty path also disables the path-checking.
If that is not possible, I agree with you regarding adding some validation to warn the user about invalid trigger conditions.
(EDIT) I did a quick research in the codebase:
-
Tag filter is only active if the trigger has any tag defined:
paperless-ngx/src/documents/matching.py
Lines 335 to 341 in d55900b
-
Correspondent filter is only active if the correspondent was set in the trigger:
paperless-ngx/src/documents/matching.py
Lines 349 to 352 in d55900b
-
Document type filter is only active if the document type was set in the trigger:
paperless-ngx/src/documents/matching.py
Lines 359 to 362 in d55900b
-
Filename filter is only active if the filename glob was set in the trigger:
paperless-ngx/src/documents/matching.py
Lines 369 to 377 in d55900b
paperless-ngx/src/documents/matching.py
Lines 281 to 288 in d55900b
-
Mailrule filter is only active if it was set in the trigger:
paperless-ngx/src/documents/matching.py
Lines 269 to 273 in d55900b
-
And, yet, the document source is always active, regardless if it was set in the trigger or left empty:
paperless-ngx/src/documents/matching.py
Line 261 in d55900b
It really sounds like an oversight, and I think it leads to surprising behavior for the user.
from paperless-ngx.
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. See our contributing guidelines for more details.
from paperless-ngx.
Related Issues (20)
- [BUG] Filename in notifications should be unescaped HOT 2
- [BUG] Split function not working on .eml files HOT 3
- [BUG] Database/Filenames get out of sync after multiple bulk-updates HOT 3
- [BUG] file with umlaut in name unlink during sanity check HOT 2
- [BUG] Warning on invalid metadata is not limited in size. HOT 3
- [BUG] [API] Paged output of documents is incomplete, contains duplicates HOT 3
- [BUG] websockets broken with channels 4.1.0+ HOT 8
- [BUG] Labeling of the button with “Redo OCR” is misleading HOT 1
- [BUG] No processing of documents after update (V 2.7.2 > 2.8.6) HOT 4
- [BUG] Altering metadata included in the storage-path of a document does not update the "Media Filename" field HOT 3
- [BUG] Updating to v2.9.0 not working
- [BUG] Just won't save to archive
- [BUG] merging of .tif broken HOT 1
- [BUG] Tag remains selected in the dropdown after it has been deselected HOT 3
- update from 2.8.6 to latest 2.9 failed with Watchtower HOT 5
- [BUG] Saved view is not filtering correctly
- [BUG] Specified key was too long; max key length is 3072 bytes HOT 3
- [BUG] When restarting docker container, if there are items still in queue they are re-added to the queue on startup HOT 5
- [BUG] Mail rules of different accounts need to have different names?!
- [BUG] Correspondent and Document Type no longer automatically populates automatically
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from paperless-ngx.