pantheon-systems / wordpress-composer Goto Github PK

WordPress for Pantheon with a composer.json file.

License: Other

PHP 65.94% CSS 14.37% JavaScript 18.51% SCSS 1.03% HTML 0.14%

wordpress-composer's Introduction

WordPress

This is a WordPress repository configured to run on the Pantheon platform.

Pantheon is website platform optimized and configured to run high performance sites with an amazing developer workflow. There is built-in support for features such as Varnish, Redis, Apache Solr, New Relic, Nginx, PHP-FPM, MySQL, PhantomJS and more.

Getting Started

1. Spin-up a site

If you do not yet have a Pantheon account, you can create one for free. Once you've verified your email address, you will be able to add sites from your dashboard. Choose "WordPress" to use this distribution.

2. Load up the site

When the spin-up process is complete, you will be redirected to the site's dashboard. Click on the link under the site's name to access the Dev environment.

3. Run the WordPress installer

How about the WordPress database config screen? No need to worry about database connection information as that is taken care of in the background. The only step that you need to complete is the site information and the installation process will be complete.

We will post more information about how this works but we recommend developers take a look at wp-config.php to get an understanding.

If you would like to keep a separate set of configuration for local development, you can use a file called wp-config-local.php, which is already in our .gitignore file.

4. Enjoy!

Branches

The default branch of this repository is where PRs are merged, and has CI that copies default to master after removing the CI directories. This allows customers to clone from master and implement their own CI without needing to worry about potential merge conflicts.

Custom Upstreams

If you are using this repository as a starting point for a custom upstream, be sure to review the documentation and pull the core files from the master branch.

wordpress-composer's People

Contributors

Stargazers

Watchers

Forkers

henryhankdc ryanbaron xaqrox nullvariable georgetown-university troutacular rcallenmg jocastaneda melvinhgf-solutions jazzsequence kporras07 kf6nux gthakur1 isabella232 askmeoffersglobal

wordpress-composer's Issues

WordPress Composer Installer Outdated

johnpbloch/wordpress-core-installer had a 1.0 release. We should require version ^1.0.

[CMSP-464] v5.9.6 installs both Pantheon mu-plugins

I was just updating an old site to the latest version of 5.9 and noticed it installed both the older /mu-plugins/pantheon plugin (and pantheon.php file) as well as the newer /mu-plugins/pantheon-mu-plugin plugin. This starts happening in 5.9.6.

Is there any reason why we can’t remove the old plugin?
https://github.com/pantheon-systems/wordpress-composer/tree/5.9.7/wp-content/mu-plugins

Currently, I have to manually delete the old plugin or else I get this error:

Fatal error: Cannot redeclare Pantheon_Cache() (previously declared in /code/web/wp-content/mu-plugins/pantheon-mu-plugin/inc/pantheon-page-cache.php:511) in /code/web/wp-content/mu-plugins/pantheon/pantheon-page-cache.php on line 546

Thanks!

Security backports for older branches are missing

While trying to pull in version 5.7.6 for a project, I noticed that this repo does not include all the security backports for older versions. As an example, the 5.7 branch only has releases up to 5.7.2.

Is this something that can be changed so that the repository includes the latest security backports for all older branches as well?

Is this a working example?

Hey! Is this a working example?

Why WordPress core files are committed to the repository?

Pantheon_Cache error on latest version

Fatal error: Cannot redeclare Pantheon_Cache() (previously declared in /app/web/wp-content/mu-plugins/pantheon-mu-plugin/inc/pantheon-page-cache.php:513) in /app/web/wp-content/mu-plugins/pantheon/pantheon-page-cache.php on line 546

Repository does not have contributing.md file

File should be added to inform new contributors of contribution guidelines.

WordPress Version is Out of Date

Current WordPress version (5.7.2) was released 12 May 2021. This repository is only updated to 5.4.1

`4.x-dev` still aliased to `dev-master` even for WordPress 5.x

The composer.json still aliases 4.x versions to dev-master even after recent update to WordPress 5.0. This introduces breaking changes. E.g. our composer.json requires this package as:

"minimum-stability": "dev",
...
"require": {
  "pantheon-systems/wordpress-composer": "^4.9"
}

The aforementioned alias then resolves ^4.9 to dev-master, which currently contains WordPress 5.0.0. This is unexpected and a breaking change.

Unintended coupling between WP Core version and Pantheon mu-plugin version

This package currently ships the default Pantheon must-use plugin within its bundled wp-content folder, to ensure caching works as intended, etc...

However, there seems to be a package design flaw here which has created an unintended coupling between versions of WordPress Core and the Pantheon must-use plugin.

We had this issue with a large multisite we have migrated over to Pantheon. To ensure we didn't introduce any unintended changes during the migration, we opted for a Composer stack with fixed versions, and we pinned the WordPress Core version down to what the original site was using: WP Core 5.7.4.

However, this has led to a 2-year-old version of the Pantheon must-use plugin to be included instead, and this is the likely culprit of massive performance issues that we saw once the site went live.

I solved this by adding the https://github.com/pantheon-systems/pantheon-mu-plugin package to the Composer stack as well, and switching the old with the new versions during a Composer post-install script.

Ideally, this Composer setup would pull in the above package as a dependency that can be kept up-to-date on composer update, instead of bundling a fixed version of it.