pantheon-systems / drops-7 Goto Github PK

It looks like the repository has been updated with all the code for 7.51 but there's no tag... which makes it hard for projects using composer to download it.

1 patch, pester Ryan Szrama
https://www.acromediainc.com/blog/drupal-commerce-performance-locking
(slide 4)

https://events.drupal.org/baltimore2017/sessions/drupal-commerce-performance

The Icons? line in the drops-7 .gitignore file keeps icon folders from being included in drops forks.

Here is an example: https://github.com/nuams/dkan-drops-7/tree/master/profiles/dkan/modules/contrib/markdowneditor/icons

Can this be amended to "Icons" or removed?

On panopoly-based sites (at least) pantheon_apachesolr fails to import the schema. This results in errors like this one on install:

WD pantheon_apachesolr: Error Could not resolve host:                    [error]
index.live.getpantheon.com posting
profiles/openberkeley/modules/contrib/search_api_solr/solr-conf/3.x/schema.xml
to
https://index.live.getpantheon.com/sites/self/environments/dev/index

That error recurs if you try to use the form at /admin/config/search/pantheon/schema to post the schema.

I believe the variable pantheon_tier is not getting set correctly. Notice this output on a dev site:

[bwood@mbp tmp]$ drush @pantheon.openucb-586.dev vget pantheon_tier
pantheon_tier: "live"

[bwood@mbp tmp]$ drush @pantheon.openucb-586-panopoly.dev vget pantheon_tier
pantheon_tier: "live"

And I can't simply change that:

[bwood@mbp tmp]$ drush @pantheon.openucb-586.dev vset pantheon_tier dev
pantheon_tier was set to "dev".                                        [success]
[bwood@mbp tmp]$ drush @pantheon.openucb-586.dev vget pantheon_tier
pantheon_tier: "live"

Per #51 drupal tags are supposed to be part of regular releases.

When a nested docroot is being used, Pantheon Solr is failing to post the schema with the following error:

Error NSS: client certificate not found: ../certs/binding.pem

The repo looks like this:

$ ll code/
total 72
drwxr-xr-x  4 4b2316bf73cb4d949a5518ac27eabbe1 4b2316bf73cb4d949a5518ac27eabbe1 4096 Aug 18 15:09 drush
drwxr-xr-x  4 4b2316bf73cb4d949a5518ac27eabbe1 4b2316bf73cb4d949a5518ac27eabbe1 4096 Aug 18 15:09 tests
-rw-r--r--  1 4b2316bf73cb4d949a5518ac27eabbe1 4b2316bf73cb4d949a5518ac27eabbe1 3622 Aug 25 14:23 Vagrantfile
-rw-r--r--  1 4b2316bf73cb4d949a5518ac27eabbe1 4b2316bf73cb4d949a5518ac27eabbe1  130 Aug 25 14:23 README.txt
drwxr-xr-x  2 4b2316bf73cb4d949a5518ac27eabbe1 4b2316bf73cb4d949a5518ac27eabbe1 4096 Aug 25 14:23 .puppet
-rw-r--r--  1 4b2316bf73cb4d949a5518ac27eabbe1 4b2316bf73cb4d949a5518ac27eabbe1  126 Aug 25 14:23 Makefile
-rw-r--r--  1 4b2316bf73cb4d949a5518ac27eabbe1 4b2316bf73cb4d949a5518ac27eabbe1 1050 Aug 25 14:23 .gitignore
-rw-r--r--  1 4b2316bf73cb4d949a5518ac27eabbe1 4b2316bf73cb4d949a5518ac27eabbe1  829 Aug 25 14:23 Gemfile.lock
-rw-r--r--  1 4b2316bf73cb4d949a5518ac27eabbe1 4b2316bf73cb4d949a5518ac27eabbe1  113 Aug 25 14:23 Gemfile
drwxr-xr-x  9 4b2316bf73cb4d949a5518ac27eabbe1 4b2316bf73cb4d949a5518ac27eabbe1 4096 Aug 25 14:23 docroot
-rw-r--r--  1 4b2316bf73cb4d949a5518ac27eabbe1 4b2316bf73cb4d949a5518ac27eabbe1  226 Aug 25 14:23 pantheon.yml
drwxr-xr-x  2 4b2316bf73cb4d949a5518ac27eabbe1 4b2316bf73cb4d949a5518ac27eabbe1 4096 Aug 25 14:23 private
drwxr-xr-x  2 4b2316bf73cb4d949a5518ac27eabbe1 4b2316bf73cb4d949a5518ac27eabbe1 4096 Aug 25 14:23 patches
drwxr-xr-x  3 4b2316bf73cb4d949a5518ac27eabbe1 4b2316bf73cb4d949a5518ac27eabbe1 4096 Aug 25 14:23 styleguide
drwxr-xr-x  3 4b2316bf73cb4d949a5518ac27eabbe1 4b2316bf73cb4d949a5518ac27eabbe1 4096 Aug 25 14:23 scripts
lrwxrwxrwx  1 4b2316bf73cb4d949a5518ac27eabbe1 4b2316bf73cb4d949a5518ac27eabbe1    9 Aug 25 14:23 web -> ./docroot
drwxr-xr-x 11 4b2316bf73cb4d949a5518ac27eabbe1 4b2316bf73cb4d949a5518ac27eabbe1 4096 Aug 25 14:23 .
drwxr-x--- 16 4b2316bf73cb4d949a5518ac27eabbe1 pantheon                         4096 Aug 25 14:44 ..
drwxr-xr-x  8 4b2316bf73cb4d949a5518ac27eabbe1 4b2316bf73cb4d949a5518ac27eabbe1 4096 Aug 25 14:49 .git

Replacing ../certs/binding.pem with ../../certs/binding.pem in the occurrences below fixed the problem.

https://github.com/pantheon-systems/drops-7/search?utf8=%E2%9C%93&q=binding.pem

The main idea here is to stop assuming the container cert (binding.pem) is always at ../certs/ and devise a clever way to detect the docroot location (or whether the site has a nested docroot or not). Checking pantheon.yml for web_docroot: true could also be a good idea.

On vanilla install of drops-7, the Pantheon profile sets sets $search_default_module to apachesolr_search and disables the core node search as a default:

https://github.com/pantheon-systems/drops-7/blob/ea54cb1d6318517582e7258e880ce02ab5a2cbfd/profiles/pantheon/pantheon.profile

  $search_active_modules = array(
    'apachesolr_search' => 'apachesolr_search',
    'user' => 'user',
    'node' => 0
  );
  variable_set('search_active_modules', $search_active_modules);
  variable_set('search_default_module', 'apachesolr_search');
  drupal_set_message(t('Pantheon defaults configured.'));

However we don't enable the Pantheon ApacheSolr module by default:

https://github.com/pantheon-systems/drops-7/blob/ea54cb1d6318517582e7258e880ce02ab5a2cbfd/profiles/pantheon/pantheon.info

  ;dependencies[] = apachesolr
;dependencies[] = apachesolr_search
dependencies[] = pantheon_api
dependencies[] = pantheon_login
;dependencies[] = pantheon_apachesolr

So when a user with permission loads /admin/config/search/settings to setup indexing for their site using the core search module, neither the node nor user radio button is selected, if they save the form without selecting one, they get the error message "An illegal choice has been detected. Please contact the site administrator." They must first enable one or both of the checkboxes and then select a radio button, for this form to submit without error:

https://github.com/pantheon-systems/drops-7/blob/master/modules/search/search.admin.inc

  $form['active']['search_active_modules'] = array(
    '#type' => 'checkboxes',
    '#title' => t('Active modules'),
    '#title_display' => 'invisible',
    '#default_value' => variable_get('search_active_modules', array('node', 'user')),
    '#options' => $module_options,
    '#description' => t('Choose which search modules are active from the available modules.')
  );
  $form['active']['search_default_module'] = array(
    '#title' => t('Default search module'),
    '#type' => 'radios',
    '#default_value' => variable_get('search_default_module', 'node'),
    '#options' => $module_options,
    '#description' => t('Choose which search module is the default.')

At the time of profile installation, the default should remain the core node search, and not be wiped out on installation of this profile, so users who are trying to configure core search can have a good experience trying to submit the form.

Per SA-CORE-2018-001.

Having the modules be in their own repositories (like pantheon-systems/pantheon, or /pantheon_api) would allow for easy distribution of the modules individually through Drush Make.

Tagging and branches allow for release version control so that you wouldn't need the -6 or -7 suffixes.

With things like php version eventually moving to pantheon.yml, it might be good to start shipping our upstream with a default file to encourage adoption and make setting a php version easier.

I have configured dbserver on search api. I am trying to index profile2 data. I am on pantheon. I have tried few things. I removed the server and added again and re-enabled. Then I tried to index 1 item. Then I downgraded my jquery to 1.4. Nothing worked. This is the error An AJAX HTTP error occurred. HTTP Result Code: 403 Debugging information follows. Path: /batch?id=102&op=do StatusText: Forbidden ResponseText: 403 error | Commerce Kickstart @import url("http://dev-resumebrowse.pantheonsite.io/modules/system/system.base.css?p5krf0"); @import url("http://dev-resumebrowse.pantheonsite.io/modules/system/system.menus.css?p5krf0"); @import url("http://dev-resumebrowse.pantheonsite.io/modules/system/system.messages.css?p5krf0"); @import url("http://dev-resumebrowse.pantheonsite.io/modules/system/system.theme.css?p5krf0"); @import url("http://dev-resumebrowse.pantheonsite.io/modules/system/system.admin.css?p5krf0"); @import url("http://dev-resumebrowse.pantheonsite.io/modules/comment/comment.css?p5krf0"); @import url("http://dev-resumebrowse.pantheonsite.io/profiles/commerce_kickstart/modules/contrib/date/date_api/date.css?p5krf0"); @import url("http://dev-resumebrowse.pantheonsite.io/profiles/commerce_kickstart/modules/contrib/date/date_popup/themes/datepicker.1.7.css?p5krf0"); @import url("http://dev-resumebrowse.pantheonsite.io/profiles/commerce_kickstart/modules/contrib/fences/field.css?p5krf0"); @import url("http://dev-resumebrowse.pantheonsite.io/modules/node/node.css?p5krf0"); @import url("http://dev-resumebrowse.pantheonsite.io/modules/user/user.css?p5krf0"); @import url("http://dev-resumebrowse.pantheonsite.io/profiles/commerce_kickstart/modules/contrib/views/css/views.css?p5krf0"); @import url("http://dev-resumebrowse.pantheonsite.io/profiles/commerce_kickstart/modules/contrib/colorbox/styles/default/colorbox_style.css?p5krf0"); @import url("http://dev-resumebrowse.pantheonsite.io/profiles/commerce_kickstart/modules/contrib/ctools/css/ctools.css?p5krf0"); @import url("http://dev-resumebrowse.pantheonsite.io/profiles/commerce_kickstart/modules/contrib/panels/css/panels.css?p5krf0"); @import url("http://dev-resumebrowse.pantheonsite.io/profiles/commerce_kickstart/modules/contrib/wysiwyg_linebreaks/wysiwyg_linebreaks.css?p5krf0"); @import url("http://dev-resumebrowse.pantheonsite.io/profiles/commerce_kickstart/themes/contrib/shiny/css/reset.css?p5krf0"); @import url("http://dev-resumebrowse.pantheonsite.io/profiles/commerce_kickstart/themes/contrib/shiny/css/style.css?p5krf0"); @import url("http://dev-resumebrowse.pantheonsite.io/profiles/commerce_kickstart/themes/contrib/shiny/css/contrib.css?p5krf0"); @import url("http://dev-resumebrowse.pantheonsite.io/profiles/commerce_kickstart/themes/contrib/shiny/css/shiny.css?p5krf0"); Skip to main content 403 error Home 403 error Access denied

Removed functions called in /misc/healthchecks/db.check.php these functions no longer exist for PHP 7

Tested using:

• search_api 7.x-1.21 + search_api_solr 7.x-1.2
• pantheon_apache_solr 7.x-1.0

and

• search_api 7.x-1.22 + search_api_solr 7.x-1.12
• pantheon_apache_solr 7.x-1.0

Solr Schema 3.x from search_api_solr posted to Pantheon.
pantheon_apache_solr status says Solr server is available and is responding to ping command.

Issues:

1. Issue 1: Search API Solr server values are not overridden with pantheon_apache_solr
2. Issue 2: Once Solr server config is adjusted manually using values deducted from pantheon_apache_solr module, Search API still reports Solr server as unavailable.
3. Issue 3: Docs page (https://pantheon.io/docs/solr-drupal-7/) requires update - at least mentioning that Search API Solr integration is not working currently (at least for specific versions of the modules above)

Issue 2 is caused by the function makeHttpRequest() (in Pantheon_Search_Api_Solr_Service.php) not using SSL certificate when connecting to Pantheon Solr.

Temporary workaround for Issue 2 for me was to replace contents of makeHttpRequest() in Pantheon_Search_Api_Solr_Service.php with the contents of _makeHttpRequest() from Pantheon_Apache_Solr_Service.php

Looking at the pantheon_apache_solr module (current HEAD of master) in general, it seems that it was updated at certain point to be compatible with apache_solr module, but search_api_solr integration was left as is and definitely requires refactoring.

I had created a support ticket from my dashboard a couple days ago regarding a module for image cropping that wasn't working (https://www.drupal.org/project/focal_point). It wasn't working after the initial crop, as any subsequent crop wasn't taking effect. I had suspected maybe something with Varnish was keeping the image from being updated.

Turns out, there seems to be a problem with the pantheon_api_image_path_flush() hook within /modules/pantheon/pantheon_api/pantheon_api.module.

I simply changed this:
$paths[] = file_uri_target($image_path);

to this:
$paths[] = '/' . file_uri_target($image_path);

... and it started working. I was told that this had been moved to Pantheon's "internal tracker", so I wasn't sure where to post this fix. I could also possibly submit a pull request if necessary.

When running Pantheon Drupal instead of vanilla Drupal the following error is triggered: "Notice: Undefined index: drupal in update_requirements() (line 35 of /path/to/modules/update/update.install)."

According to PSA-2018-001, there will be a critical security update released today. Lately, updates to core don't ever seem to get pushed to this repo until someone creates an issue. Can we make sure this one gets done ASAP?

We have tests running on pull request for some of our major repositories like https://github.com/pantheon-systems/drops-8 and https://github.com/pantheon-systems/WordPress. Adding similar tests here to verify installation and basic administrative tasks will give us more confidence in merging pull requests.

There is a Power Users thread for posting Solr schema upon multidev creation: https://groups.google.com/a/pantheon.io/forum/#!topic/power-users/sowAXap1bOk

While the "upon multidev creation" is likely out of the scope of this repo, the posting itself could be made more scriptable with a drush command.

I'm thinking of a command that could be invoked like drush pantheon-apachesolr-post-schema --schema=sites/all/modules/contrib/apachesolr/solr-conf/solr-3.x/schema.xml

The drush piece would be relatively simple, just a wrapper around pantheon_apachesolr_post_schema_exec()

@greg-1-anderson, can I get your thoughts before I proceed with writing the drush command?

There were two minor omissions to the 7.79 release due to a problem with applying the patch.

• menu.inc is missing a change to a comment (no difference in behavior)
• common.inc is missing a minor bug fix (will not cause problems for sites, beyond missing out on the fix)

The diff between the drops-7 common.inc and Drupal's common.inc is as follows:

--- includes/common.inc	2021-04-08 08:05:07.000000000 -0700
+++ /Users/ga/Code/open-source/drupal/drupal-7/includes/common.inc	2021-04-08 08:37:01.000000000 -0700
@@ -3676,7 +3676,7 @@ function drupal_build_css_cache($css) {
     $uri = $map[$key];
   }
 
-  if (empty($uri) || !drupal_aggregated_file_exists($uri)) {
+  if (empty($uri) || !file_exists($uri)) {
     // Build aggregate CSS file.
     foreach ($css as $stylesheet) {
       // Only 'file' stylesheets can be aggregated.
@@ -5120,19 +5120,6 @@ function drupal_add_tabledrag($table_id,
   drupal_add_js($settings, 'setting');
 }
 
-function drupal_aggregated_file_exists($uri) {
-  if (function_exists('apc_exists')) {
-    $exists = apc_exists('file_exists_' . $uri);
-    if (!$exists && file_exists($uri)) {
-      $exists = TRUE;
-      apc_store('file_exists_' . $uri, TRUE, 86400);
-    }
-    return $exists;
-  }
-  // If no APC available, fall back to default.
-  return file_exists($uri);
-}
-
 /**
  * Aggregates JavaScript files into a cache file in the files directory.
  *
@@ -5172,7 +5159,7 @@ function drupal_build_js_cache($files) {
     $uri = $map[$key];
   }
 
-  if (empty($uri) || !drupal_aggregated_file_exists($uri)) {
+  if (empty($uri) || !file_exists($uri)) {
     // Build aggregate JS file.
     foreach ($files as $path => $info) {
       if ($info['preprocess']) {
@@ -5180,10 +5167,8 @@ function drupal_build_js_cache($files) {
         $contents .= file_get_contents($path) . ";\n";
       }
     }
-
-    // Allow modules to act on the js_cache before writing to disk.
-    drupal_alter('js_cache', $contents);
-
+    // Remove JS source and source mapping urls or these may cause 404 errors.
+    $contents = preg_replace('/\/\/(#|@)\s(sourceURL|sourceMappingURL)=\s*(\S*?)\s*$/m', '', $contents);
     // Prefix filename to prevent blocking by firewalls which reject files
     // starting with "ad*".
     $filename = 'js_' . drupal_hash_base64($contents) . '.js';

The first few differences related to drupal_aggregated_file_exists are Pantheon additions. The drupal_alter is from Pressflow. The last difference to fix 404 errors related to JS source and source mapping is a fix in Drupal 7.79 that did not apply cleanly since it was made next to the Pressflow addition.

Hello,

I’m trying to figure out how to test the solr index on the Execute Query page.
I found this document, http://coder1.com/articles/analyze-your-solr-index-pantheon
but this syntax isn’t working with the Pantheon Execute Query.

I'd like to see the type and title of the content, but the syntax doesn't let that happen.

the "Icon" entry in the .gitignore file is causing the following module to not be included:

https://www.drupal.org/project/icon

An extra file, includes/common.inc.orig, was committed to this repo as part of the recent 7.61 update. I imagine this is a leftover/cruft file created while git was merging the upstream drupal.org changes to common.inc and was not added intentionally.

Not every site has drupal core search enabled. Yet this module depends on permissions that are set in that to access the admin page of the pantheon admin screen. There is not even a dependancy mentioned in the info file of the module... yet it requires the 'administer search' permission be set @see pantheon_apachesolr_menu.

Either add a dependancy to the core search, or create your own permission. The second option is better as not every one running solr search has core search enabled. and fix documentation at https://pantheon.io/docs/solr-drupal/

I have Search API already installed, but am enabling Pantheon Apache Solr for the first time on this instance. It looks like until the schema is posted, this PHP notice appears on every cache clear:

Notice: Undefined index: name in search_api_help() (line 188 of /srv/bindings/c7df118083a04f74bf4227b9cb4dc66e/code/sites/default/modules/contrib/search/search_api/search_api.module).

I am using Search API 1.22.

Hi. I am running through and updating some sites to 7.71. Normally, the one-click method does just fine. However, we're now hitting merge conflicts using this method to update core. The conflicts from one-click are:

CONFLICT (content): Merge conflict in scripts/run-tests.sh,CONFLICT (content): Merge conflict in modules/taxonomy/taxonomy.install,CONFLICT (content): Merge conflict in modules/system/system.test,CONFLICT (content): Merge conflict in modules/simpletest/simpletest.info,CONFLICT (content): Merge conflict in modules/search/search.module,CONFLICT (content): Merge conflict in modules/search/search.extender.inc,CONFLICT (content): Merge conflict in modules/forum/forum.module,CONFLICT (content): Merge conflict in modules/filter/filter.api.php,CONFLICT (content): Merge conflict in modules/field_ui/field_ui.module,CONFLICT (content): Merge conflict in modules/field_ui/field_ui.admin.inc,CONFLICT (content): Merge conflict in modules/field/tests/field_test.storage.inc,CONFLICT (content): Merge conflict in modules/field/modules/number/number.test,CONFLICT (content): Merge conflict in modules/comment/comment.test,CONFLICT (content): Merge conflict in modules/comment/comment.install,CONFLICT (content): Merge conflict in modules/color/color.module,CONFLICT (content): Merge conflict in modules/block/block.module,CONFLICT (content): Merge conflict in misc/typo3/phar-stream-wrapper/src/Resolver/PharInvocationResolver.php,CONFLICT (content): Merge conflict in misc/typo3/phar-stream-wrapper/src/PharStreamWrapper.php,CONFLICT (content): Merge conflict in misc/typo3/phar-stream-wrapper/src/Phar/Reader.php,CONFLICT (content): Merge conflict in misc/typo3/phar-stream-wrapper/src/Helper.php,CONFLICT (content): Merge conflict in misc/typo3/phar-stream-wrapper/composer.json,CONFLICT (content): Merge conflict in misc/typo3/phar-stream-wrapper/README.md,CONFLICT (modify/delete): misc/typo3/phar-stream-wrapper/.gitignore deleted in upstream/master and modified in HEAD. Version HEAD of misc/typo3/phar-stream-wrapper/.gitignore left in tree.,CONFLICT (content): Merge conflict in misc/ajax.js,CONFLICT (content): Merge conflict in includes/request-sanitizer.inc,CONFLICT (content): Merge conflict in includes/path.inc,CONFLICT (content): Merge conflict in includes/menu.inc,CONFLICT (content): Merge conflict in includes/filetransfer/filetransfer.inc,CONFLICT (content): Merge conflict in includes/batch.inc

As an alternative, I ran git pull -Xtheirs git://github.com/pantheon-systems/drops-7.git master locally and everything updated except for misc/typo-3/phar-stream-wrapper/.gitignore. Looks like that file was deleted in the Drops-7 repository but my local copy remained. Removing the file and pushing the local changes up to my site seemed to work just fine. Just curious if I'm the only one seeing this with the latest update. Thanks!

https://github.com/pantheon-systems/drops-7/blob/master/modules/pantheon/pantheon_api/pantheon_api.module#L20L21

Seems like pantheon_bulk_file_delete() has been retired (internal reference: dts comment in BUGS-1599)

I create a little patch for pantheon apache solr. https://gist.github.com/jacintocapote/b6a8d848f91f00c49881
The patch add a new permission to access to administer pages of pantheon apache solr. Because the module use 'access administer pages' but we have a case where the user can access to some administer pages and not to pantheon apache solr settings.

I have a folder in pantheon on our dev environment that is writable by a script that create temporary files. It's not drupal related to much in the sense that it takes a drupal RSS feed and converts it to MRSS and creates a temp file in this folder.

In dev this folder works fine. I'm about to write to it without issue and destroy the contents later. However once i push to test and live I get write permissions issues. I'm assuming this has something to do with SFTP mode, but the fact that both environments don't act the same makes developing a pain.

My question is, are we able to have writable folders within test and live that live outside of drupal? If not how would someone handle this type of need? I don't want to have to setup an outside resource for something this simple.

Drupal 7.30 was released on last week Thursday. It fixes an important regression in Drupal 7.29. Can you guys please do your magic and update drops-7 for that release? Thanks! :-)

I've been waiting to update the Panopoly repo for Pantheon so that I can merge the update to Drupal 7.30 from this repo, rather than doing it manually, so these two repos can stay in sync.

Or is it just assumed to roll master all the time?

Hi, thanks for maintaining this repo.

Would it be possible to have a branch which doesn't include the CI files, or to temporarily remove them for each tagged release?

./circle-ci
./gitlab-ci
./.gitlab-ci.yml

Thanks in advance!