pangolindex / pangolin.exchange Goto Github PK

The Pangolin subgraph will be used to get data.

It would be good to have a tutorial on how to run the pangolin subgraph locally with an Avalanche node.

The Graph documentation focuses on an running a local Ethereum node with a 10 test accounts and some Eth loaded on all the accounts.

Would be great if we could create a tutorial on how to run an avash template locally connecting to the fuji testnet and then how we can configure the subgraph repo on how to connect.

One of the ways we could do this would be to introduce a .env file to the subgraph repo and then just add the tutorial.

I'm happy taking this on board, however I'm still trying to understand the broader contributing status quo

The Pangolin team should consider introducing various terms and conditions, privacy policy and disclaimers across the site. I've been using Pangolin since it started and there are several areas that are worth exploring further:

1. Terms and Conditions of Use. This should incorporate exclusion provisions and indemnities designed to give developers some measure of protection if there is catastrophic failure or funds are lost. There should also be rights to exclude users/wallets who breach acceptable use terms, use the site for unlawful purposes etc...

2. Privacy Policy. What does Pangolin do with trading and account information that can be attributed to a user? How does it process, store, and distributed that data? Where is it stored? Who has access to it?

3. Disclaimers at the point of key trading and liquidity decisions. There aren't any warnings yet. That's not good practice.

4. US-focused disclaimers and exclusions. I strongly recommend the team consider whether Pangolin is going to be subject to US Securities and Exchanges laws and how to manage that risk. There are other jurisdictions that may not look kindly on Pangolin operations so it would be smart to think about mitigating that risk.

5. Licensing, copyright terms. Who owns the code? Who owns the site? Who is paying for hosting? On what conditions can it be used? If open-source, which open source terms are being used? They should be referenced on the site.

6. I didn't see any age restrictions. I know it's hard to manage this risk but the team should turn their mind to how they might be able to exclude minors. You can't have kids trading on Pangolin. That would be a public relations disaster and would definitely attract an official response.

Obviously I've only summarised the key issues to consider - there is quite a bit of complexity to each of these topics given the multi-jurisdictional questions raised. Some can be solved with legal drafting. Others require some coding. Some might not have an answer - this is bleeding edge legal territory.

At the moment, if someone from the community would like to contribute there's no easy way to understand the flow of what that will look like.

Could we create a Contributing guidelines document that covers some of the following:

• PR process - what does this look like?
• Acceptance criteria - What does the code need to look like for the PR to be merged? Does it need to include code coverage? Are we using static code analysers, for example SonarQube
• Branching strategy
• Version strategy - are we using semantic versioning

As an aside, it would be pretty good to have a license assigned to the project if possible

https://github.com/pangolindex/pangolin.exchange/blob/master/src/routes/index.svelte#L200-L262