When including an external library in your plugin, you must include a thirdpartylibs.xml file that includes the name, location and license of the library.
More information on this is here:
https://docs.moodle.org/dev/Plugin_files#thirdpartylibs.xml
And here:
https://docs.moodle.org/dev/Plugin_with_third_party_libraries

One of the other advantages of using this is that Moodle's codechecker automatically ignores any files included in the location specificed in the thirdpartylibs.xml file.

Please note - this is typically a blocker for approval in the plugins db.

more info here:
https://docs.moodle.org/dev/Security:Cross-site_request_forgery#What_you_need_to_do_in_your_code

When adding a new module in empty Moodle 4.0 I get the notices:

( ! ) Notice: Trying to get property 'id' of non-object in /var/www/html/moodle40/mod/dynamo/lib.php on line 1084
Call Stack

Time Memory Function Location

1 0.0000 363816 {main}( ) .../view.php:0
2 0.1675 8222456 require_once( '/var/www/html/moodle40/mod/dynamo/student.php' ) .../view.php:169
3 0.1679 8222968 dynamo_get_body_table_teacher( ) .../student.php:148

( ! ) Notice: Trying to get property 'id' of non-object in /var/www/html/moodle40/mod/dynamo/lib.php on line 1098
Call Stack

Time Memory Function Location

1 0.0000 363816 {main}( ) .../view.php:0
2 0.1675 8222456 require_once( '/var/www/html/moodle40/mod/dynamo/student.php' ) .../view.php:169
3 0.1679 8222968 dynamo_get_body_table_teacher( ) .../student.php:148

Thanks for the plugin.
I'm a PT-PT translator.

Is this hardcoded to French?

In:

trim function has boolean as the argument $comment1 == ''.

What you probably meant is to run trim on $comment1:
if (trim($comment1) == '') {

The same for $comment2 below.

Bonjour,

Je suis l'administrateur d'une plateforme Moodle 3.11.14+

Je viens de mettre à jour notre serveur php de la version 7.3 à la version 8.0.28

Depuis cette mise à jour je reçois ce message d'erreur lorsque je souhaite accéder à un cours disposant d'une activité Dynamo
Exception : Undefined constant "FEATURE_MOD_PURPOSE"
Debug info:
Error code: generalexceptionmessage
Stack trace:
line 49 of /mod/dynamo/lib.php: Error thrown
line 8109 of /lib/moodlelib.php: call to dynamo_supports()
line 2037 of /lib/modinfolib.php: call to plugin_supports()
line 524 of /lib/modinfolib.php: call to cm_info->__construct()
line 417 of /lib/modinfolib.php: call to course_modinfo->__construct()
line 2380 of /lib/modinfolib.php: call to course_modinfo::instance()
line 63 of /lib/classes/content.php: call to get_fast_modinfo()
line 219 of /course/view.php: call to core\content::can_export_context()
Exception : Undefined constant "FEATURE_MOD_PURPOSE"
Debug info:
Error code: generalexceptionmessage
Stack trace:
line 49 of /mod/dynamo/lib.php: Error thrown
line 8109 of /lib/moodlelib.php: call to dynamo_supports()
line 2037 of /lib/modinfolib.php: call to plugin_supports()
line 524 of /lib/modinfolib.php: call to cm_info->__construct()
line 417 of /lib/modinfolib.php: call to course_modinfo->__construct()
line 2380 of /lib/modinfolib.php: call to course_modinfo::instance()
line 2054 of /lib/navigationlib.php: call to get_fast_modinfo()
line 2118 of /lib/navigationlib.php: call to global_navigation->generate_sections_and_activities()
line 502 of /course/format/lib.php: call to global_navigation->load_generic_course_sections()
line 234 of /course/format/tiles/lib.php: call to format_base->extend_course_navigation()
line 2033 of /lib/navigationlib.php: call to format_tiles->extend_course_navigation()
line 1398 of /lib/navigationlib.php: call to global_navigation->load_course_sections()
line 3510 of /lib/navigationlib.php: call to global_navigation->initialise()
line 3555 of /lib/navigationlib.php: call to navbar->has_items()
line 4590 of /lib/outputrenderers.php: call to navbar->get_items()
line 52 of /theme/boost_campus/layout/columns2.php: call to core_renderer->region_main_settings_menu()
line 1401 of /lib/outputrenderers.php: call to include()
line 1331 of /lib/outputrenderers.php: call to core_renderer->render_page_layout()
line 2867 of /lib/outputrenderers.php: call to core_renderer->header()
line 390 of /lib/setuplib.php: call to core_renderer->fatal_error()
line ? of unknownfile: call to default_exception_handler()

Pourriez-vous m'aider à corriger ce problème.
Bien cordialement,

functions should be moved into a lib file like locallib.php and need to follow our frankenstyle naming conventions:
https://docs.moodle.org/dev/Frankenstyle#Function_names

I see a few places where you add user->firstname and user->lastname together manually. Usually you should be using moodle's fullname() api to do this as some sites will display name fields in different ways.

not a blocker for plugins db approval.

The install.xml is no longer valid and was either created for an old version of Moodle or has been handwritten.

This needs to be fixed using the Moodle xmldb editor (under admin > development > XMLDB.)

Please hit the "load" link for your plugin install.xml file in the moodle xmldb editor, and then make Moodle think there is an update to the file (easiest way to do this is to change the description of a table - add a full stop or something similar.) Then get XMLDB to "Save" the updated file which will remove all the old invalid xml from your file.

direct access to raw $_GET/$_POST/$_REQUEST is not allowed.

https://github.com/Palumdo/moodle-mod_dynamo/blob/master/save.php#L79-L100 etc

Please change this to using moodle's optional/required_param functions with appropriate PARAM_XXX cleaning.

note - this is a blocker for approval in the plugins db.

more info here:
https://docs.moodle.org/dev/Security#Don.27t_trust_any_input_from_users