Describe the bug
When executing cft with autoscale, cft fails to create EIPs. Error provided is "Invalid value 'VPC' for domain." CFT rolls back.
Expected behavior
EIPs are successfully created.
Current behavior
See above.
Possible solution
Current firewall-new-vpc-v3.0.template contains code similar to the following:
"EIP1" : {
"Type" : "AWS::EC2::EIP",
"Properties" : {
"Domain" : "VPC"
},
"DependsOn": [ "VPC", "GatewayToInternet", "IGW" ]
},
Modify firewall-new-vpc-v3.0.template as follows:
"EIP1" : {
"Type" : "AWS::EC2::EIP",
"Properties" : {
"Domain" : "vpc"
},
"DependsOn": [ "VPC", "GatewayToInternet", "IGW" ]
},
Repeat these modifications for EIP1, EIP2, EIP3 and EIP4 definitions.
Steps to reproduce
Deploy CFT as per instructions. The following will be the result:
![EIP1-error](https://user-images.githubusercontent.com/47675470/108646334-72c54200-7483-11eb-945f-0422b9a94883.png)