pablospaniard / f1-3-c2p1-colmar-academy Goto Github PK

I wasn't able to get your mobile styles to display for me on a mobile view. It is good practice to add the following line to your head when you're using media queries with width delimiters. This will ensure mobile styles will appear.

Adding this inside your HTML gave me your mobile styles.

<meta name="viewport" content="width=device-width, initial-scale=1">

Here's some further reading on this line. Check out the viewport sections.

https://developers.google.com/web/fundamentals/design-and-ui/responsive/

Tiny comment, but make sure you indent head and body from your html element as they're children of html. Just something to keep in mind, but a tiny tiny issue :)

https://github.com/redstardeveloper/f1-3-c2p1-colmar-academy/blob/master/ColmarAcademySub/index.html#L4-L13

You have done a good job on the organization of your HTML & CSS! The class names are specific, everything is indented (except for head/body tags), and there's no areas of confusion! Keeping your code clean like this is a great sign for employers!

Good work!

Grade: Exceeds Expectations

Summary: This project is excellent! It meets the spec and the code is clean/free of any errors. No major areas of improvement, other than making sure to keep as consistent indentation as possible (head/body), so keep up the good work!

As a challenge, a great exercise would be expanding the site with links to the other pages, making minor style tweaks to these pages (the importance here is just getting to practice building multi-page sites). This will give you experience with building and managing a multi-page website.

Good work!

Not so much an issue as maybe a spec interpretation. I've always thought the spec meant for a full-width page, but you have a fixed-width page. Honestly, your page looks great so I wouldn't worry about it, but just something to keep in mind from the spec!