vbproj files partially updated about automaticpackagerestoremigrationscript HOT 6 CLOSED

It looks like the expression got removed... here it is:

$simpleBadStuff = @"
<Import Project="`$(SolutionDir)\.nuget\nuget.targets" />
"@

from automaticpackagerestoremigrationscript.

I also noticed that the resulting vbproj files contains erroneous hintpath elements ($(SolutionDir)packages...). I thnik there's a missing "" in the hintPath replacement value. I think it should be like below.

$content = $content -replace $hintPathPattern, "<HintPath>`$(SolutionDir)\packages"

from automaticpackagerestoremigrationscript.

I like the idea from your first comment. Probably going to implement that. It's also interesting that your $(SolutionDir) doesn't end in a slash. Might need to add a check for that.

from automaticpackagerestoremigrationscript.

Not sure if the actual $(SolutionDir) ends or not with a , but when I look at other usages of this macro in the vbproj files I see Microsoft always add a \ after the macro.

I'm also investigating an issue where the element below don't get removed even if there's an expression for it in the script. I suspect the regex is too specific.

<Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
    <PropertyGroup>
      <ErrorText>This project references NuGet package(s) that are missing on this computer. Enable NuGet Package Restore to download them.  For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
    </PropertyGroup>
    <Error Condition="!Exists('$(SolutionDir)\.nuget\NuGet.targets')" Text="$([System.String]::Format('$(ErrorText)', '$(SolutionDir)\.nuget\NuGet.targets'))" />
  </Target>

from automaticpackagerestoremigrationscript.

Here's the solution I found to correctly remove the Target element:

$nugetBuildImportsPattern = @"
\s*<Target Name="EnsureNuGetPackageBuildImports".*?</Target>\s
"@
[...]
$content = [Regex]::Replace($content, $nugetBuildImportsPattern, "", @('Singleline', 'Ignorecase'))

from automaticpackagerestoremigrationscript.

this should be fixed in another pull request

from automaticpackagerestoremigrationscript.