ovidigital / js-object-to-json Goto Github PK

Hi! Thank you for you project!
I hope it can help me to parse data from a JS file.
I have a following example of JS data:

var some_data = {data: s("London")};

where s is a translation function used in JS code. I need to get an array or PHP object from that.
Unfortunately, such code can't be processed with the json_decode function that you use under the hood. It says Syntax Error.
If I call convertToJson I get:

{"data":"s(""London")}

Double quote appears, which should not be there. Do you think if there's any workaround for that?

Hi Ovi,

Your example code has an error in the capitalization of the namespace:

// Convert the Javascript object to JSON format
$json = \Ovidigital\JsObjectToJson\JsConverter::convertToJson($jsObjectString);

Should actually be:

// Convert the Javascript object to JSON format
$json = \OviDigital\JsObjectToJson\JsConverter::convertToJson($jsObjectString);

This drove me crazy for about half an hour!

Lets say this is your JS object

constmyObject = {
   "myPropertyA": "myValue",
   "myPropertyB": "myValue"
};

The JS object minified

const myObject={"myPropertyA":"myValue","myPropertyB":"myValue"};

When I use this package, it does not remove the "constmyObject = " or the ";" linebreak at the end of the object.

Please allow for the automatic removal of the object name and the line break at the end of the object.

Example input string for convertToJson:

{"data": true}

Expected result:

{"data": true}

Actual result:

{"data": "true"}

Hi

I found a new case when parsing the javascript object fails:

{
    "metadata": "{\"title\":\"Some // Title\"}"
}

The parsed result is NULL.

$convertedString is immediately overridden, please check this code fragment.
Inspection info: Identifies assignments immediately overriding values in non-trivial contexts.

Hi

The changes introduced in the 1.1.2 version breaks the old parsing mechanism.
Here you can find the example code:

<?php

use OviDigital\JsObjectToJson\JsConverter;

include 'vendor/autoload.php';

$input = '{sources:[],image:"http://127.0.0.1/sapsdvcx3kgq.jpg",duration:"3200",width:"100%"}';

var_dump(JsConverter::convertToJson($input));

Output with version 1.1.1:

string(91) "{"sources":[],"image":"http://127.0.0.1/sapsdvcx3kgq.jpg","duration":"3200","width":"100%"}"

Output with version 1.1.2:

string(30) "{"sources":[],"image:""http":""

                                 ^
                                 completly broken

I think the \OviDigital\JsObjectToJson\JsConverter::removeComments() is not production ready.

Hi!
Found one more case that does not work.
Data for convertToJson, it's a one-line string:

{id:304,name: "Anna's house",jobs:[{id:3041,title: "Drive to Anna's house.",label: "Drive",steps:3}]}

Expected result:

{"id":304,"name":"Anna's house","jobs":[{"id":3041,"title": "Drive to Anna's house.","label":"Drive","steps":3}]}

Actual result:

{"id":304,"name":"Anna's house\",jobs:[{id:3041,title: \"Drive to Anna's house.","label":"Drive","steps":3}]}

Sample code:

$result = \OviDigital\JsObjectToJson\JsConverter::convertToJson('{id:304,name: "Anna\'s house",jobs:[{id:3041,title: "Drive to Anna\'s house.",label: "Drive",steps:3}]}');
echo $result;

Could you please improve the package to handle this case?

<?php

include 'vendor/autoload.php';

// A variable containing a JavaScript object as a string
$jsObjectString = "{ foo:  'bar', }";

// Convert the Javascript object to JSON format
$json = \OviDigital\JsObjectToJson\JsConverter::convertToJson($jsObjectString);

var_dump($json);

The current output is string(14) "{"foo":"bar",}"