Comments (4)
Can you elaborate this more, I don't want to be rude but your text is heavily confusing, provide also some sample code
from forgottenserver.
Can you elaborate this more, I don't want to be rude but your text is heavily confusing, provide also some sample code
E.g. there is:
if (it.abilities->stats[STAT_MAGICPOINTS]) {
if (begin) {
begin = false;
s << " (";
} else {
s << ", ";
}
s << "magic level " << std::showpos << it.abilities->stats[STAT_MAGICPOINTS] << std::noshowpos;
}
but at the same time a code that was omitted:
// MISSING ONES:
if (it.abilities->stats[STAT_MAXHITPOINTS]) {
s << ", max health " << std::showpos << it.abilities->stats[STAT_MAXHITPOINTS] << std::noshowpos;
}
if (it.abilities->stats[STAT_MAXMANAPOINTS]) {
s << ", max health " << std::showpos << it.abilities->stats[STAT_MAXMANAPOINTS] << std::noshowpos;
}
etc.
Then it would be good to remove those if's and put them into separate method:
Pseudocode
addStatsToDesc(s&, it);
addStatsToDesc(s, it) {
if (it.abilities->stats[STAT_MAGICPOINTS]) {
if (begin) {
begin = false;
s << " (";
} else {
s << ", ";
}
s << "magic level " << std::showpos << it.abilities->stats[STAT_MAGICPOINTS] << std::noshowpos;
}
// MISSING ONES:
if (it.abilities->stats[STAT_MAXHITPOINTS]) {
s << ", max health " << std::showpos << it.abilities->stats[STAT_MAXHITPOINTS] << std::noshowpos;
}
if (it.abilities->stats[STAT_MAXMANAPOINTS]) {
s << ", max health " << std::showpos << it.abilities->stats[STAT_MAXMANAPOINTS] << std::noshowpos;
}
}
I think that some of abilities.stats and abilities.statsPercent are missing. Maybe some others too.
from forgottenserver.
Yea I agree the monstrosity of that should have been re worked already.
I might give this a shot once I'm done with my current PR's, I'll add it to the 1.6 milestone that we don't forget about it.
from forgottenserver.
I guess I was sent slightly older src, as currently tfs has moved that into lua.
So it doesn't really matter anymore. It's still 600+ lines method there, so it still could be broken into smaller segments (https://github.com/otland/forgottenserver/blob/master/data/lib/core/item.lua#L151), but atleast there are comments included.
from forgottenserver.
Related Issues (20)
- Unresolved external symbol 'main'.
- Incorrectly displaying special skills
- CMake issues in Visual Studio HOT 3
- Wrong interactions of monsters with pathfinding. HOT 7
- Chat channel onJoin message gets send to all others but not the one that joined HOT 2
- World Light HOT 2
- Where to get a valid tibia client assets for testing? HOT 1
- Deprecated MySQL feature (MYSQL_OPT_RECONNECT)
- Create an .env.example file
- Inventory Slots - Equipment Classic Slots HOT 1
- Info: XZ library and vcpkg HOT 2
- moveUpStairs() HOT 2
- SQLite save support? HOT 4
- Compiling error with VCPKG HOT 7
- classicAttackSpeed makes server go 100% CPU
- Bug transfering gold to player who doesn't exist in bank NPC HOT 3
- How do Conditions work and why do we need them? HOT 1
- PERMANENT (conditions) or (buffs/debuffs) to player that lasts even through death and login/logout HOT 2
- docker build failing HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from forgottenserver.