Code Monkey home page Code Monkey logo

Comments (4)

EvilHero90 avatar EvilHero90 commented on September 24, 2024

Can you elaborate this more, I don't want to be rude but your text is heavily confusing, provide also some sample code

from forgottenserver.

Tofame avatar Tofame commented on September 24, 2024

Can you elaborate this more, I don't want to be rude but your text is heavily confusing, provide also some sample code

E.g. there is:

                       if (it.abilities->stats[STAT_MAGICPOINTS]) {
				if (begin) {
					begin = false;
					s << " (";
				} else {
					s << ", ";
				}

				s << "magic level " << std::showpos << it.abilities->stats[STAT_MAGICPOINTS] << std::noshowpos;
			}

but at the same time a code that was omitted:

                        // MISSING ONES:
			if (it.abilities->stats[STAT_MAXHITPOINTS]) {
				s << ", max health " << std::showpos << it.abilities->stats[STAT_MAXHITPOINTS] << std::noshowpos;
			}
			if (it.abilities->stats[STAT_MAXMANAPOINTS]) {
				s << ", max health " << std::showpos << it.abilities->stats[STAT_MAXMANAPOINTS] << std::noshowpos;
			}

etc.

Then it would be good to remove those if's and put them into separate method:
Pseudocode

addStatsToDesc(s&, it);
   
addStatsToDesc(s, it) {
	if (it.abilities->stats[STAT_MAGICPOINTS]) {
		if (begin) {
			begin = false;
			s << " (";
		} else {
			s << ", ";
		}

		s << "magic level " << std::showpos << it.abilities->stats[STAT_MAGICPOINTS] << std::noshowpos;
	}

	// MISSING ONES:
	if (it.abilities->stats[STAT_MAXHITPOINTS]) {
		s << ", max health " << std::showpos << it.abilities->stats[STAT_MAXHITPOINTS] << std::noshowpos;
	}
	if (it.abilities->stats[STAT_MAXMANAPOINTS]) {
		s << ", max health " << std::showpos << it.abilities->stats[STAT_MAXMANAPOINTS] << std::noshowpos;
	}
}

I think that some of abilities.stats and abilities.statsPercent are missing. Maybe some others too.

from forgottenserver.

EvilHero90 avatar EvilHero90 commented on September 24, 2024

Yea I agree the monstrosity of that should have been re worked already.
I might give this a shot once I'm done with my current PR's, I'll add it to the 1.6 milestone that we don't forget about it.

from forgottenserver.

Tofame avatar Tofame commented on September 24, 2024

I guess I was sent slightly older src, as currently tfs has moved that into lua.

So it doesn't really matter anymore. It's still 600+ lines method there, so it still could be broken into smaller segments (https://github.com/otland/forgottenserver/blob/master/data/lib/core/item.lua#L151), but atleast there are comments included.

from forgottenserver.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.