osoc16 / mijn-viaa Goto Github PK

Need to test the loading of API responses arriving at a different time -> if possible, a random simulated delay on different responses would be awesome.

• Make a separate page for VIAA global stats (publicly available) -> Big CTA on dashboard & about page
• On user's stats, compare with VIAA global (for example: 20TB (17% of total VIAA storage))
• Put VIAA global stats on about page
• Branch feature/thegrandreformationv2 already has the VIAA global view removed (the code turns out to be a lot cleaner as well) - merge when decision is made

when clicking on dashboard

The readme as of now only explains (very basicly) how to set up the Front-End side.
Would be nice to also have the same for the Node server.

Options:

1. Every single graph gets its personal variable that gets passed to View
   -> +: as soon as a graph is finished, it gets displayed
   -> +/-: Every graph has (/can have) its own loading spinning thing -> might be too much
   -> -: lots of variables passed to view
2. Pass 1 'graph finished' variable to view
   -> +: easy coding
   -> -: Wait for slowest call, and then show all the graphs at once
   Kind of like it is now, but as soon as 1 graph is done, loading circle will disappear, graph will show -> No warning / feedback on graphs yet to come
   -> Might be a good option (will 1 graph realistically be multiple seconds later than others and does this even matter?)
3. Not possible: Make a nice object and set graphs as properties
   -> Vue can NOT detect changes to object properties
4. Some array magic maybe?

The service icons should be next to the text in tablet size and not above the text

When an ajax call responds with a 401 error, a page refresh should be done. This way the page will be redirected to the login.

In scss/main.scss, the button is not respecting box-sizing:border-box and drawing the border on the outside of the div.

The first value needs to start at the sum of everything before it.

cumulative graphs now start at 0 + {first value}, but should be {total of everything before} +{first value}`

Depending on the user's access and organisation, certain services will be shown or hidden.

eg. DBS contracts should not be shown for users with restricted access

If I'm correct, server needs to allow to set the 'max-age' http header

http://stackoverflow.com/questions/25727306/request-header-field-access-control-allow-headers-is-not-allowed-by-access-contr

https://developers.google.com/web/fundamentals/performance/optimizing-content-efficiency/http-caching?hl=en

Manually entering a service that doesn't exist after detail.html# will attempt to get hard coded & API data.

Needs to display a proper 'Service (/page) not found' error.

This button should have its own style, being a recurring functionality -> Should be instantly recognizable as different from the 'go to service' CTA

• Interrupt previous Ajax calls in refresh() function
• Maybe disable the dropdown menu while calls are going (meh)
• Or build in some check to prevent new ajax calls from starting while others are running

parseBarchart() is generic for all graphs -> use for all graphs
parseLineChart() is only for line chart -> remove

• Push error messages to object -> Filter in view to show err msg
• Clear old graphs (graphs now overlap if new ones are taken)
• Loading icons / messages
• Think about error displays
• Aesthetics plz

 Front-end
    ||
    ||  /api/stats + cookie/session
    \/
NGNIX-CACHE
    ||
    ||  /api/stats + cookie/session
    \/
 Backend (cookie/session -> org)
    ||
    ||  /api/stats?org=vrt
    \/
   Mule

Org-A-person who asks for /api/stats != Org-B-person who asks for /api/stats

So NGNIX cannot cache, but browser can. (unless same computer + browser used by people of different organisations)

Currently the static files are not accessible when the server would be deployed.

Add a 'static files' folder to the server so that: html, css, js, assets are accessible

Concat js files on dist & doublecheck if unused scripts are loaded (jquery @ home for example)

Implement them.

• add libraries
• config environment for auth export NODE_ENV="dev_auth"
• API: error when not logged in
• PAGES: redirect to login service when not logged in for pages

http://do-qas-esb-01.do.viaa.be:10005/api/stats/global

needs VPN connection

JSend format for JSON responses

Success

Required keys:

• status: Should always be set to "success".
• data: Acts as the wrapper for any data returned by the API call. If the call returns no data (as in the last example), data should be set to null.

{
    status : "success",
    data : { ... } | null

Fail

When an API call is rejected due to invalid data or call conditions, the JSend object's data key contains an object explaining what went wrong, typically a hash of validation errors.
Required keys:

• status: Should always be set to "fail".
• data: Again, provides the wrapper for the details of why the request failed. If the reasons for failure correspond to POST values, the response object's keys SHOULD correspond to those POST values.

{
    "status" : "fail",
    "data" : { ... } // details why failed
}

Error

Required keys:

• status: Should always be set to "error".
• message: A meaningful, end-user-readable (or at the least log-worthy) message, explaining what went wrong.

Optional keys:

• code: A numeric code corresponding to the error, if applicable

- data: A generic container for any other information about the error, i.e. the conditions that caused the error, stack traces, etc.

{
    "status" : "error",
    "message" : "..."
}

API call happens every time a user goes to home page -> limit API calls & cache data

When the Ajax call fails on the mainpage, the preloader keeps "loading" and the error message is only returned in the console.
On the other pages it's the same thing (no feedback if the API is down)
It would be nice to have a pop-up or something to give the user feedback when the API services don't work (which shouldn't happen in an ideal world, but crap happens)

• server/routes/api.js all muletest stuff

• LICENCE.md
• at top of all files

QuickFix

• frontend link GET/logout
• backend logout backend + redirect IDP logout

Actual fix

• frontend: POST /logout (ajax call)
• backend: logout iDP then logout backend