osmoscraft / osmosnote Goto Github PK

After navigating to linked notes, navigating back (Atl + left in most browsers) caused scroll to reset to page top.

This is necessary for adding line breaks when a line ends with the link

• When inside a list item, press Enter should create a new item below with the same indentation level
• Press Backspace immediately after split will clear the bullet and reset indentation to 0
• Press Enter immediately after split will clear the bullet while retaining the current indentation

rg 13.0.0 stopped working with osmosnote. Need to investigate on the root cause.

For reference, the maintainer of rg provided additional guidance here: BurntSushi/ripgrep#2056

Expected: YYYYMMDDHHMMSS
Actual: YYYYMMDDHHMMLLL (where LLL is the millisecond portion of the timestamp)

It appears that the browser cannot detect xmodmap as arrow key events. Investigate whether we can use keyName instead of keyCode in javascript

environment

windows 10 19042.1288
WSL: ubuntu Linux DESKTOP-RG3539D 5.10.16.3-microsoft-standard-WSL2 #1 SMP Fri Apr 2 22:23:49 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
docker desktop 4.0.1

issue description

I tried deploying osmosnote in Docker and setup a storage，when i run :

root@DESKTOP-RG3539D:/home/bob# sudo docker run -p 6684:6684 -e "OSMOSNOTE_REPO_DIR=/home/bob/osmosdata" -v /home/bob/osmosdata:/data -v /etc/passwd:/etc/passwd:ro -v /etc/group:/etc/group:ro -u 1000:1000 osmoscraft/osmosnote

i get the error info:

rgPath: /usr/bin/rg
rgVersion: 12.1.1 (rev a9a05b88c5)
gitPath: /usr/bin/git
gitVersion: 2.30.2
xargsPath: /usr/bin/xargs
xargsVersion: 4.8.0
[config] Username: bob
[config] env OSMOSNOTE_REPO_DIR: /home/bob/osmosdata
[config] env OSMOSNOTE_SERVER_PORT: 6683
[config] Creating dir: /home/bob/osmosdata
[config] Error creating repo directory: /home/bob/osmosdata Error: EACCES: permission denied, mkdir '/home/bob/osmosdata'
    at Object.mkdirSync (node:fs:1334:3)
    at Object.module2.exports.makeDirSync (/usr/local/bin/osmosnote/dist/main.js:39655:18)
    at ensureRepoConfig (/usr/local/bin/osmosnote/dist/main.js:56910:31)
    at async run (/usr/local/bin/osmosnote/dist/main.js:57931:3) {
  errno: -13,
  syscall: 'mkdir',
  code: 'EACCES',
  path: '/home/bob/osmosdata'
}

but i found the home/bob/osmosdata directory creation succeeded

Ctrl + Enter to insert and move to new line below
Ctrl + Shift + Enter to insert and move to new line above

When using selected text to search, allow ctrl + enter to insert a matched result while also replacing the selected text with matched title.

When git client uses main as the default, local repo will be initialized with main and later push to a remote main.

The fix would respect the choice from the remote while creating the local branch. If the creation happened offline, the sync should rename local branch to whatever the remote uses.

e.g. with keybinding ctrl+space q

This would allow server to run in background without the need for the terminal

Current implementation uses scrollIntoView, which does not always restore the exact position. A better algorithm should

1. Store editor scroll top value, alone with editor dimensions
2. On reload, set focus to restore target, and determine scroll
   1. If editor dimension has not changed, set scroll top to stored value
   2. If editor dimension has changed, fallback to current implementation, i.e. scroll focused node into view

Additionally:

1. We need to restore cursor selection status
2. Need to restore to last clicked link, see #13 .

URL should be case sensitive and all casing must be preserved when going through the parser