osmanatam / delphi-foundations Goto Github PK

Hi Chris,

Make CCR.CocoaToolbar.pas compile on XE7 with the following change:

function NSWindowOfForm(Form: TCommonCustomForm): NSWindow;
{$if CompilerVersion > 26.0}
var
  Obj: TOCLocal;
{$ifend}
begin
  {$if CompilerVersion > 26.0}
  Result:= TMacWindowHandle(Form.Handle).Wnd;
  {$else}
  Obj := (FmxHandleToObjC(Form.Handle) as TOCLocal);
  Result := NSWindow(TOCLocalAccess(Obj).Super);
  {$ifend}
end;

I don't know when TMacWindowHandle was introduced so $CompilerVersion may be 
wrong. But after this change the demo works fine on XE7.

In the demo the Enabled property of toolbar item has to be initialized, 
otherwise there are sometimes disabled. So in Main.pas add handler for all 
items:

  Item := FHelper.AddItem('FileOpen');
  Item.OnUpdate :=
    procedure (Sender: TNSToolbarHelperItem; var EnableItem: Boolean)
    begin
      EnableItem:= True; // add this
    end;

Best regards
Dirk Carstensen

What steps will reproduce the problem?
1. Created Android app to use CCR.PrefsIniFile.Android custom ini file
2. write a boolean true to the ini file and exit the application
3. Enter the app and read the boolean - its always false (the default I guess)

What is the expected output? What do you see instead?
Should be true, is always false

What version of the product are you using? On what operating system?
XE5. Android Samsung Galaxy S3

Please provide any additional information below.
Since I am unfamiliar with these files, I cannot be sure if its not writing the 
value correctly, not reading value correctly or both.

In further testing, using the AndroidPreferences demo, I found that writing a 
boolean gets written, but when read it comes in as false. If you read it in as 
a string it shows the value "true". So something seems to be wrong with reading 
a boolean value from the file. To work around this I will change the readbool 
to readstring and work from there.