os-ucsd / graffiti-wall Goto Github PK
View Code? Open in Web Editor NEWThis project forked from eceusc/graffiti-wall
Learn Pull Requests by tagging on our graffiti wall!
This project forked from eceusc/graffiti-wall
Learn Pull Requests by tagging on our graffiti wall!
Whenever someone makes a PR to our graffiti wall, we run a test (with circleCI) to make sure any new .json
file in the tags
directory is valid (8x8, defined color, a name is provided, etc.). This test is written in python in test.py
.
However, if someone accidentally adds their JSON file to the project root directory (and not in the tags
directory), the test would not catch it, because the the test only looks at whatever is inside the tags
directory.
We need a new test in the test.py
file. Add a new method to class TestTags
, say def test_tags_in_tags(self)
, that will loop through the project directory, and ensure there are not JSON files in the top-level project directory. So, get every file that's in the current directory, loop through every file and check to see if the file name ends in .json
. If so, then let's just assume that the file is an accidental top-level tail, and let's have the test fail.
This happened in this PR #50 . They added a emac.json
file not in the tags
directory, and the tests still passed. I fixed it in this commit f6933bf by just renaming the file to tags/emac.json
.
If this doesn't make sense or it's confusing, just lmk! More than happy to explain further or help out a bit ๐
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.