Code Monkey home page Code Monkey logo

orbs-ethereum-contracts-v1's Introduction

Orbs Ethereum Contracts Monorepo

CircleCI

orbs-ethereum-contracts-v1's People

Contributors

andr444 avatar bolshchikov avatar electricmonk avatar erankirsh avatar gilamran avatar itamararjuan avatar jlevison avatar lbeder avatar natesimantov avatar noambergil avatar odedwx avatar orlavy avatar ronnno avatar talkol avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

orbs-ethereum-contracts-v1's Issues

Add "%" to column values

Is your feature request related to a problem? Please describe.
People are confused by "Last election votes against (%)" column

A clear and concise description of what the problem is. E.g, I'm always frustrated when [...]

Describe the solution you'd like
In the last column on https://orbs-network.github.io/voting/guardian page add "%" to the values displayed in the column

A clear and concise description of what you want to happen. If applicable, consider adding a code example of how you'd like to use the feature.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered. If applicable, provide links to alternative solutions/features in other projects.

Additional context

Add any other context or screenshots about the feature request here.

An error in "Delegation details" - unrefreshed erroneous fields

Describe the bug

A clear and concise description of what the bug is.

When checking an address that delegates, then checking an address that doesn't, some of the fields in "Delegation Details" do not refresh
The fields are:

  • Guardian voted in previous elections
  • Guardian voted for next elections

Another issue - for the address 0x86b234a86d57E707fBE1A406780941FDaB6690A5 these fields are empty, though the address delegates to a valid Guardian

Steps To Reproduce

Steps to reproduce the behavior:

  1. Go to "https://orbs-network.github.io/voting/reward"
  2. Input a delegating address - such as 0x6dda3D258e21Abc37668E82aE543e8C77567F220
  3. Scroll down to Delegation Details
  4. See the fields populated with green YES
  5. Input a non-delegating address - such as
    0xD5C78e498A1BF8d3fb88BA9a2dD71f6931c590D0
  6. The fields are still populated with YES, though there is no delegation. Should be blank

Expected behavior

All fields should update according to the correct information

Logs

If applicable, provide the link to the log files that contain the issue.

Screenshots

If applicable, add screenshots to help explain your problem.

Environment:

If applicable, add the information about that you are running and their versions

Additional context

If possible, provide the failing test the reveals the issue.
Add any other context about the problem here.

Change "None-Delegated" to "Not delegated"

Describe the bug

Seems to be a misspelling of the term
Change "None-Delegated" to "Not delegated" in this project

Steps To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

A clear and concise description of what you expected to happen.

Logs

If applicable, provide the link to the log files that contain the issue.

Screenshots

If applicable, add screenshots to help explain your problem.

Environment:

If applicable, add the information about that you are running and their versions

Additional context

If possible, provide the failing test the reveals the issue.
Add any other context about the problem here.

Display orbs total stake

Display total amount of orbs stake in a formatted manner
new Intl.NumberFormat('en').format(337966591)

Upgrdes - go over all flows

  1. Who is the owner of each contract?

  2. Who deploys each contract? (to set the owner correctly)

  3. How do we upgrade each component?

Display delegation info next to rewards

Is your feature request related to a problem? Please describe.

Users would like to see all relevant information in one place regarding rewards. Providing info about just rewards is not enough, it should be put in the context.

Describe the solution you'd like

We propose to add one more table below rewards table with the following information:


Delegation Details

Delegated to 0x12345678910121314
Delegator's Orbs Balance 1234
Voted in previous elections Yes/No
Voted for next elections Yes/No

Validator stakes missing commas

Describe the bug
On https://orbs-network.github.io/voting/validator there should be commas in the Validator stakes, such as "4,344,593 ORBS" instead of "4344593 ORBS"
Also, to shorten the column, change column title to "Stake (in ORBS)" and drop the word "ORBS" from the cells, leaving just the number (with commas)

A clear and concise description of what the bug is.

Steps To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

A clear and concise description of what you expected to happen.

Logs

If applicable, provide the link to the log files that contain the issue.

Screenshots

If applicable, add screenshots to help explain your problem.

Environment:

If applicable, add the information about that you are running and their versions

Additional context

If possible, provide the failing test the reveals the issue.
Add any other context about the problem here.

Add effective elections block

Is your feature request related to a problem? Please describe.

When the data is displayed in rewards page, it is unclear to which elections it's related.

Describe the solution you'd like

Provide text in small under (*) with elections block number

Additional context

API:

getEffectiveElectionsBlockNumber.json
{
   “ContractName”: “_Elections”,
   “MethodName”: “getEffectiveElectionBlockNumber”,
   “Arguments”: [
   ]
}

Sum of "% in last election" over 100%

Describe the bug

A clear and concise description of what the bug is.
Sum of "% in last election" over 100%

Steps To Reproduce

Steps to reproduce the behavior:

  1. Go to https://orbs-network.github.io/voting/delegator
  2. Click on '....'
  3. Scroll down to '....'
  4. See error - in "% in last election"

Expected behavior

Sum of "% in last election" should be 100%

Logs

If applicable, provide the link to the log files that contain the issue.

Screenshots

If applicable, add screenshots to help explain your problem.

Environment:

If applicable, add the information about that you are running and their versions

Additional context

If possible, provide the failing test the reveals the issue.
Add any other context about the problem here.

Add "Already distributed" value

Is your feature request related to a problem? Please describe.

A clear and concise description of what the problem is. E.g, I'm always frustrated when [...]

Describe the solution you'd like
On the rewards page at https://orbs-network.github.io/voting/reward add a value called "Received rewards" with the sum of all rewards this address received so far.

A clear and concise description of what you want to happen. If applicable, consider adding a code example of how you'd like to use the feature.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered. If applicable, provide links to alternative solutions/features in other projects.

Additional context

Add any other context or screenshots about the feature request here.

Display Wrong delegation

Describe the bug

A clear and concise description of what the bug is.

Steps To Reproduce

Steps to reproduce the behavior:

  1. Go to 'Hedron'
  2. Click on 'Rewards'
  3. Search 0xF0DB4646e4be8e2094cD6d7c6D253a87Eec7af58
  4. See "Delegated To"

this address is new guardian "Good relation-Guardian"'s address.
But Hedron says he's delegating another guardian (whom used to delegated before registering as a guardian)
https://orbs-network.github.io/voting/reward?address=0xF0DB4646e4be8e2094cD6d7c6D253a87Eec7af58
I can see calculation is okay (he's staked token looks on himself), then it may be display issue.

Expected behavior

A clear and concise description of what you expected to happen.

Logs

If applicable, provide the link to the log files that contain the issue.

Screenshots

If applicable, add screenshots to help explain your problem.

Environment:

If applicable, add the information about that you are running and their versions

Additional context

If possible, provide the failing test the reveals the issue.
Add any other context about the problem here.

Incorrect Validators balance

Describe the bug
https://orbs-network.github.io/voting/validator
The balance is incorrect, showing 0 for addresses that just received rewards
A clear and concise description of what the bug is.

Steps To Reproduce

Steps to reproduce the behavior:

  1. Go to https://orbs-network.github.io/voting/validator
  2. See balance
  3. Scroll down to '....'
  4. See error

Expected behavior
Show correct, up-to-date Validators balance
A clear and concise description of what you expected to happen.

Logs

If applicable, provide the link to the log files that contain the issue.

Screenshots

If applicable, add screenshots to help explain your problem.

Environment:

If applicable, add the information about that you are running and their versions

Additional context

If possible, provide the failing test the reveals the issue.
Add any other context about the problem here.

voting/ethereum CI is flaky

https://circleci.com/gh/orbs-network/orbs-ethereum-contracts/713

flaky failure on unit tests in CI - truffle has issues downloading a solidity compiler

+ npm run migrate

> [email protected] migrate /home/circleci/project/voting/ethereum
> truffle migrate --reset

- Fetching solc version list from solc-bin
- Downloading compiler
Error: Could not find a compiler version matching 0.5.3. Please ensure you are specifying a valid version, constraint or build in the truffle config. Run `truffle compile --list` to see available versions.
    at VersionRange.errors (/home/circleci/project/voting/ethereum/node_modules/truffle/build/webpack:/packages/truffle-compile/compilerSupplier/loadingStrategies/LoadingStrategy.js:57:1)
    at VersionRange.getSatisfyingVersionFromCache (/home/circleci/project/voting/ethereum/node_modules/truffle/build/webpack:/packages/truffle-compile/compilerSupplier/loadingStrategies/VersionRange.js:86:1)
    at VersionRange.load (/home/circleci/project/voting/ethereum/node_modules/truffle/build/webpack:/packages/truffle-compile/compilerSupplier/loadingStrategies/VersionRange.js:186:1)
Truffle v5.0.5 (core: 5.0.5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.